Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Smart Menu font color in 2nd level differs from 1st level and might even be invisible #459

Closed
BerengarWLehr opened this issue Nov 7, 2023 · 4 comments
Assignees
Labels
bug Something which isn't working

Comments

@BerengarWLehr
Copy link

As visible in the screenshots color and background-color are not in line with the 1st level colors. The text is invisible due to the rule

.navbar.navbar-dark.bg-dark .nav-link, .navbar.navbar-dark.bg-primary .nav-link {
    color: #fff;
}

background color is overriden by

.moremenu .nav-link:hover, .moremenu .nav-link:focus {
    border-color: transparent;
    background-color: #f8f9fa;
}

moodle-dev uni-jena de_my_
moodle-dev uni-jena de_my_ (2)

It would be splendid if the 2nd level would behave as the 1st level (also using the same border-radius) but also as the following css rule:

.moremenu .dropdownmoremenu > .dropdown-menu .dropdown-menu .dropdown-item:hover,
.moremenu .dropdownmoremenu > .dropdown-menu .dropdown-menu .dropdown-item:focus {
    color: #fff;
    background-color: #002350;
}
@BerengarWLehr BerengarWLehr changed the title Bug: Smart Menu font color in 2nd level is overridden in navbar-dark Bug: Smart Menu font color in 2nd level differs from 1st level and might even be invisible Nov 7, 2023
@BerengarWLehr
Copy link
Author

My not-so-nice-fix is:

/* Fix für Github Boost Union Issue #459 */
.navbar.navbar-dark.bg-dark .dropdown-item + ul > li > a,
.navbar.navbar-dark.bg-primary .dropdown-item + ul > li > a {
    color: inherit;
}
.navbar.navbar-dark.bg-dark .dropdown-item + ul > li > a:hover,
.navbar.navbar-dark.bg-dark .dropdown-item + ul > li > a:focus,
.navbar.navbar-dark.bg-primary .dropdown-item + ul > li > a:hover,
.navbar.navbar-dark.bg-primary .dropdown-item + ul > li > a:focus {
    color: #fff !important;
    background-color: #002350;
}
.dropdown-menu > .dropdown-submenu > ul {
    border-radius: 0 !important;
}
/* Ende Fix */

@whuml whuml added the discussion needed Something which needs to be discussed before writing the first line of code label Nov 9, 2023
@whuml whuml moved this to To do REQ in Boost Union Planning Board Nov 9, 2023
@whuml
Copy link
Collaborator

whuml commented Nov 9, 2023

Dear @BerengarWLehr ,
we try to reproduce as soon as our testengine avail.
Thanks for reporting meanwhile - comming back :-)

@wiebkemueller-hsh wiebkemueller-hsh added the bug Something which isn't working label Nov 10, 2023
@wiebkemueller-hsh wiebkemueller-hsh moved this from To do REQ to Ready for DEV in Boost Union Planning Board Nov 29, 2023
@wiebkemueller-hsh wiebkemueller-hsh removed the discussion needed Something which needs to be discussed before writing the first line of code label Jan 18, 2024
@wiebkemueller-hsh
Copy link
Collaborator

wiebkemueller-hsh commented Jan 18, 2024

Info: @kaaermes and @BerengarWLehr The fix is in planning for the next smart menu dev cycle :-)

@HsH-Wolf HsH-Wolf moved this from Ready for DEV to In Progress DEV in Boost Union Planning Board Jan 30, 2024
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Mar 22, 2024
@abias abias moved this from In Progress DEV to In Progress REVIEW in Boost Union Planning Board Apr 7, 2024
abias pushed a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Apr 16, 2024
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Jun 20, 2024
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Jan 17, 2025
abias pushed a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Feb 4, 2025
@abias
Copy link
Member

abias commented Feb 4, 2025

Many thanks for your patience with this issue.
The smart menus' 3rd level presentation has received a redesign which will land in PR #602 quite soon.
Within this PR, this issue here will be solved or rather become superfluous.

In the unexpected case that PR #602 will introduce new hovering issues, a follow-up issue should be opened.

@abias abias closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from In Progress REVIEW to Ready for BACKPORT in Boost Union Planning Board Feb 4, 2025
@abias abias moved this from Ready for BACKPORT to CLOSED in Boost Union Planning Board Feb 4, 2025
abias pushed a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something which isn't working
Projects
Status: CLOSED
Development

No branches or pull requests

5 participants