Behat test optimisations #765
Assignees
Labels
improvement
Something which improves an existing feature in some way (UX, UI, Design, Functionality)
test
Something which targets automated tests (Behat, PHPUnit)
Comments
marxjohnson
added
the
new
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…oodle-an-hochschulen#765) This creates generators and named selectors for smart menus and smart menu items, plus some navigation URLs for the smart menu settings forms.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…dle-an-hochschulen#765). This performs several optimisations to make these tests a lot faster. Creation of smart menus and menu item has been changed to use generators, rather than filling the forms each time. Manual navigation has been replaced with `I am on the 'identifier' 'type' page` as much as possible. The assertions being made have been optimised. Previously, every assertion of what was in a menu was opening each menu location and checking for each item. Given that there's no option to display different items when a menu is in different location, a lot of this is redunant, and actually opening each menu takes time. I have optimised this so that one scenario does a check that the menu opens and the items are actually visible. Then each scenario tests than an expected item exists in each menu (without opening the menu) and checks for subsequent items just check existance in a single menu. This balances coverage of the different functionality with speed and conciseness of tests.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…hochschulen#765) Navigation steps have been optimised a bit, creation of blocks now uses generators, and @javascript has been removed from tests that do not require it. Only tests using the off-canvas block region need Javascript since it opens the overlay. Otherwise, we are just checking whether block regions exist or not under various circumstances, which can be done much quicker without Javascript.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…oodle-an-hochschulen#765) This creates generators and named selectors for smart menus and smart menu items, plus some navigation URLs for the smart menu settings forms.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…dle-an-hochschulen#765). This performs several optimisations to make these tests a lot faster. Creation of smart menus and menu item has been changed to use generators, rather than filling the forms each time. Manual navigation has been replaced with `I am on the 'identifier' 'type' page` as much as possible. The assertions being made have been optimised. Previously, every assertion of what was in a menu was opening each menu location and checking for each item. Given that there's no option to display different items when a menu is in different location, a lot of this is redunant, and actually opening each menu takes time. I have optimised this so that one scenario does a check that the menu opens and the items are actually visible. Then each scenario tests than an expected item exists in each menu (without opening the menu) and checks for subsequent items just check existance in a single menu. This balances coverage of the different functionality with speed and conciseness of tests.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…hochschulen#765) Navigation steps have been optimised a bit, creation of blocks now uses generators, and @javascript has been removed from tests that do not require it. Only tests using the off-canvas block region need Javascript since it opens the overlay. Otherwise, we are just checking whether block regions exist or not under various circumstances, which can be done much quicker without Javascript.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…oodle-an-hochschulen#765) This creates generators and named selectors for smart menus and smart menu items, plus some navigation URLs for the smart menu settings forms.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…dle-an-hochschulen#765). This performs several optimisations to make these tests a lot faster. Creation of smart menus and menu item has been changed to use generators, rather than filling the forms each time. Manual navigation has been replaced with `I am on the 'identifier' 'type' page` as much as possible. The assertions being made have been optimised. Previously, every assertion of what was in a menu was opening each menu location and checking for each item. Given that there's no option to display different items when a menu is in different location, a lot of this is redunant, and actually opening each menu takes time. I have optimised this so that one scenario does a check that the menu opens and the items are actually visible. Then each scenario tests than an expected item exists in each menu (without opening the menu) and checks for subsequent items just check existance in a single menu. This balances coverage of the different functionality with speed and conciseness of tests.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…hochschulen#765) Navigation steps have been optimised a bit, creation of blocks now uses generators, and @javascript has been removed from tests that do not require it. Only tests using the off-canvas block region need Javascript since it opens the overlay. Otherwise, we are just checking whether block regions exist or not under various circumstances, which can be done much quicker without Javascript.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…oodle-an-hochschulen#765) This creates generators and named selectors for smart menus and smart menu items, plus some navigation URLs for the smart menu settings forms.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…dle-an-hochschulen#765). This performs several optimisations to make these tests a lot faster. Creation of smart menus and menu item has been changed to use generators, rather than filling the forms each time. Manual navigation has been replaced with `I am on the 'identifier' 'type' page` as much as possible. The assertions being made have been optimised. Previously, every assertion of what was in a menu was opening each menu location and checking for each item. Given that there's no option to display different items when a menu is in different location, a lot of this is redunant, and actually opening each menu takes time. I have optimised this so that one scenario does a check that the menu opens and the items are actually visible. Then each scenario tests than an expected item exists in each menu (without opening the menu) and checks for subsequent items just check existance in a single menu. This balances coverage of the different functionality with speed and conciseness of tests.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…hochschulen#765) Navigation steps have been optimised a bit, creation of blocks now uses generators, and @javascript has been removed from tests that do not require it. Only tests using the off-canvas block region need Javascript since it opens the overlay. Otherwise, we are just checking whether block regions exist or not under various circumstances, which can be done much quicker without Javascript.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…dle-an-hochschulen#765). This performs several optimisations to make these tests a lot faster. Creation of smart menus and menu item has been changed to use generators, rather than filling the forms each time. Manual navigation has been replaced with `I am on the 'identifier' 'type' page` as much as possible. The assertions being made have been optimised. Previously, every assertion of what was in a menu was opening each menu location and checking for each item. Given that there's no option to display different items when a menu is in different location, a lot of this is redunant, and actually opening each menu takes time. I have optimised this so that one scenario does a check that the menu opens and the items are actually visible. Then each scenario tests than an expected item exists in each menu (without opening the menu) and checks for subsequent items just check existance in a single menu. This balances coverage of the different functionality with speed and conciseness of tests.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…hochschulen#765) Navigation steps have been optimised a bit, creation of blocks now uses generators, and @javascript has been removed from tests that do not require it. Only tests using the off-canvas block region need Javascript since it opens the overlay. Otherwise, we are just checking whether block regions exist or not under various circumstances, which can be done much quicker without Javascript.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…dle-an-hochschulen#765). This performs several optimisations to make these tests a lot faster. Creation of smart menus and menu item has been changed to use generators, rather than filling the forms each time. Manual navigation has been replaced with `I am on the 'identifier' 'type' page` as much as possible. The assertions being made have been optimised. Previously, every assertion of what was in a menu was opening each menu location and checking for each item. Given that there's no option to display different items when a menu is in different location, a lot of this is redunant, and actually opening each menu takes time. I have optimised this so that one scenario does a check that the menu opens and the items are actually visible. Then each scenario tests than an expected item exists in each menu (without opening the menu) and checks for subsequent items just check existance in a single menu. This balances coverage of the different functionality with speed and conciseness of tests.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…hochschulen#765) Navigation steps have been optimised a bit, creation of blocks now uses generators, and @javascript has been removed from tests that do not require it. Only tests using the off-canvas block region need Javascript since it opens the overlay. Otherwise, we are just checking whether block regions exist or not under various circumstances, which can be done much quicker without Javascript.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…dle-an-hochschulen#765). This performs several optimisations to make these tests a lot faster. Creation of smart menus and menu item has been changed to use generators, rather than filling the forms each time. Manual navigation has been replaced with `I am on the 'identifier' 'type' page` as much as possible. The assertions being made have been optimised. Previously, every assertion of what was in a menu was opening each menu location and checking for each item. Given that there's no option to display different items when a menu is in different location, a lot of this is redunant, and actually opening each menu takes time. I have optimised this so that one scenario does a check that the menu opens and the items are actually visible. Then each scenario tests than an expected item exists in each menu (without opening the menu) and checks for subsequent items just check existance in a single menu. This balances coverage of the different functionality with speed and conciseness of tests.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…hochschulen#765) Navigation steps have been optimised a bit, creation of blocks now uses generators, and @javascript has been removed from tests that do not require it. Only tests using the off-canvas block region need Javascript since it opens the overlay. Otherwise, we are just checking whether block regions exist or not under various circumstances, which can be done much quicker without Javascript.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 22, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
abias
added
test
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 25, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 25, 2024
…oodle-an-hochschulen#765) This creates generators and named selectors for smart menus and smart menu items, plus some navigation URLs for the smart menu settings forms.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 25, 2024
…dle-an-hochschulen#765). This performs several optimisations to make these tests a lot faster. Creation of smart menus and menu item has been changed to use generators, rather than filling the forms each time. Manual navigation has been replaced with `I am on the 'identifier' 'type' page` as much as possible. The assertions being made have been optimised. Previously, every assertion of what was in a menu was opening each menu location and checking for each item. Given that there's no option to display different items when a menu is in different location, a lot of this is redunant, and actually opening each menu takes time. I have optimised this so that one scenario does a check that the menu opens and the items are actually visible. Then each scenario tests than an expected item exists in each menu (without opening the menu) and checks for subsequent items just check existance in a single menu. This balances coverage of the different functionality with speed and conciseness of tests.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 25, 2024
…hochschulen#765) Navigation steps have been optimised a bit, creation of blocks now uses generators, and @javascript has been removed from tests that do not require it. Only tests using the off-canvas block region need Javascript since it opens the overlay. Otherwise, we are just checking whether block regions exist or not under various circumstances, which can be done much quicker without Javascript.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 25, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 25, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 25, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
marxjohnson
added a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Nov 25, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
abias
moved this from Ready for REVIEW
to In Progress REVIEW
in Boost Union Planning Board
abias
pushed a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Dec 7, 2024
…oodle-an-hochschulen#765) This creates generators and named selectors for smart menus and smart menu items, plus some navigation URLs for the smart menu settings forms.
abias
pushed a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Dec 7, 2024
…dle-an-hochschulen#765). This performs several optimisations to make these tests a lot faster. Creation of smart menus and menu item has been changed to use generators, rather than filling the forms each time. Manual navigation has been replaced with `I am on the 'identifier' 'type' page` as much as possible. The assertions being made have been optimised. Previously, every assertion of what was in a menu was opening each menu location and checking for each item. Given that there's no option to display different items when a menu is in different location, a lot of this is redunant, and actually opening each menu takes time. I have optimised this so that one scenario does a check that the menu opens and the items are actually visible. Then each scenario tests than an expected item exists in each menu (without opening the menu) and checks for subsequent items just check existance in a single menu. This balances coverage of the different functionality with speed and conciseness of tests.
abias
pushed a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Dec 7, 2024
…hochschulen#765) Navigation steps have been optimised a bit, creation of blocks now uses generators, and @javascript has been removed from tests that do not require it. Only tests using the off-canvas block region need Javascript since it opens the overlay. Otherwise, we are just checking whether block regions exist or not under various circumstances, which can be done much quicker without Javascript.
abias
pushed a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Dec 7, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
abias
pushed a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Dec 7, 2024
…oodle-an-hochschulen#765) This creates generators and named selectors for smart menus and smart menu items, plus some navigation URLs for the smart menu settings forms.
abias
pushed a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Dec 7, 2024
…dle-an-hochschulen#765). This performs several optimisations to make these tests a lot faster. Creation of smart menus and menu item has been changed to use generators, rather than filling the forms each time. Manual navigation has been replaced with `I am on the 'identifier' 'type' page` as much as possible. The assertions being made have been optimised. Previously, every assertion of what was in a menu was opening each menu location and checking for each item. Given that there's no option to display different items when a menu is in different location, a lot of this is redunant, and actually opening each menu takes time. I have optimised this so that one scenario does a check that the menu opens and the items are actually visible. Then each scenario tests than an expected item exists in each menu (without opening the menu) and checks for subsequent items just check existance in a single menu. This balances coverage of the different functionality with speed and conciseness of tests.
abias
pushed a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Dec 7, 2024
…hochschulen#765) Navigation steps have been optimised a bit, creation of blocks now uses generators, and @javascript has been removed from tests that do not require it. Only tests using the off-canvas block region need Javascript since it opens the overlay. Otherwise, we are just checking whether block regions exist or not under various circumstances, which can be done much quicker without Javascript.
abias
pushed a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Dec 7, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
abias
added a commit
that referenced
this issue
Dec 7, 2024
Behat optimisations, addresses #765 (405 backport)
abias
pushed a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Dec 7, 2024
…oodle-an-hochschulen#765) This creates generators and named selectors for smart menus and smart menu items, plus some navigation URLs for the smart menu settings forms.
abias
pushed a commit
to marxjohnson/moodle-theme_boost_union
that referenced
this issue
Dec 7, 2024
…le-an-hochschulen#765) As with other smart menu features, this uses generators, navigation steps and named selectors to speed up the tests. There is more that can be done to the feature, as time allows.
abias
added a commit
that referenced
this issue
Dec 7, 2024
Behat optimisations, addresses #765 (404 backport)
abias
added a commit
that referenced
this issue
Dec 7, 2024
abias
added a commit
that referenced
this issue
Dec 7, 2024
…at-optimisations-404 Revert " Behat optimisations, addresses #765 (404 backport)"
abias
moved this from In Progress REVIEW
to Ready for BACKPORT
in Boost Union Planning Board
abias
moved this from Ready for BACKPORT
to Ready for RELEASE
in Boost Union Planning Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This plugin has a very comprehensive suite of behat tests, which is good, especially considering the range of features it implements.
However, the current suite takes about 4 hours to run, which presents a bit of a barrier when contributing fixes.
I captured the timings (in seconds) for each feature. Looking at the smart menu tests in particular, there is definitely scope for optimising these with generators, navigation URLs and named selectors. I will submit a branch with some improvements.
{ "theme\/boost_union\/tests\/behat\/theme_boost_union_smartmenusettings_menuitems_dynamiccourses.feature": 3099.5, "theme\/boost_union\/tests\/behat\/theme_boost_union_feelsettings_blocks.feature": 3016.7, "theme\/boost_union\/tests\/behat\/theme_boost_union_smartmenusettings_menuitems_rules.feature": 2833.1, "theme\/boost_union\/tests\/behat\/theme_boost_union_smartmenusettings_menus_rules.feature": 2303.5, "theme\/boost_union\/tests\/behat\/theme_boost_union_contentsettings_staticpages.feature": 1690.8, "theme\/boost_union\/tests\/behat\/theme_boost_union_smartmenusettings_menus_presentation.feature": 1258.6, "theme\/boost_union\/tests\/behat\/theme_boost_union_smartmenusettings_menuitems_presentation.feature": 1194.3, "theme\/boost_union\/tests\/behat\/theme_boost_union_contentsettings_slider.feature": 1085.2, "theme\/boost_union\/tests\/behat\/theme_boost_union_contentsettings_footer.feature": 784.8, "theme\/boost_union\/tests\/behat\/theme_boost_union_feelsettings_navigation.feature": 486.3, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_course.feature": 468.7, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_sitebranding.feature": 424.3, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_scss.feature": 408.8, "theme\/boost_union\/tests\/behat\/theme_boost_union_contentsettings_advertisementtiles.feature": 367.6, "theme\/boost_union\/tests\/behat\/theme_boost_union_flavourssettings_caching.feature": 359.9, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_activitybranding.feature": 336.3, "theme\/boost_union\/tests\/behat\/theme_boost_union_smartmenusettings_menuitems_management.feature": 326.6, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_loginpage.feature": 308, "theme\/boost_union\/tests\/behat\/theme_boost_union_contentsettings_infobanners.feature": 296.4, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_dashboardmycourses.feature": 230.2, "theme\/boost_union\/tests\/behat\/theme_boost_union_flavourssettings_application.feature": 211.4, "theme\/boost_union\/tests\/behat\/theme_boost_union_smartmenusettings_menus_management.feature": 199.8, "theme\/boost_union\/tests\/behat\/theme_boost_union_feelsettings_links.feature": 158.4, "theme\/boost_union\/tests\/behat\/theme_boost_union_smartmenusettings_menuitems_application.feature": 155.9, "theme\/boost_union\/tests\/behat\/theme_boost_union_functionalitysettings_courses.feature": 152.6, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_blocks.feature": 143.4, "theme\/boost_union\/tests\/behat\/theme_boost_union_smartmenusettings_menus_application.feature": 125.4, "theme\/boost_union\/tests\/behat\/theme_boost_union_flavourssettings_look.feature": 103.3, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_page.feature": 83.1, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_mobile.feature": 73, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_resources.feature": 71.9, "theme\/boost_union\/tests\/behat\/theme_boost_union_flavourssettings_management.feature": 58.7, "theme\/boost_union\/tests\/behat\/theme_boost_union_goodiesfordesigners.feature": 58.1, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_h5p.feature": 45, "theme\/boost_union\/tests\/behat\/theme_boost_union_general.feature": 42.1, "theme\/boost_union\/tests\/behat\/theme_boost_union_feelsettings_misc.feature": 41, "theme\/boost_union\/tests\/behat\/theme_boost_union_functionalitysettings_administration.feature": 36.9, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_emailbranding.feature": 34.3, "theme\/boost_union\/tests\/behat\/theme_boost_union_feelsettings_pagelayouts.feature": 24.1, "theme\/boost_union\/tests\/behat\/theme_boost_union_managers.feature": 21.3, "theme\/boost_union\/tests\/behat\/theme_boost_union_tasks.feature": 15.6, "theme\/boost_union\/tests\/behat\/theme_boost_union_looksettings_generalsettings.feature": 12.8 }The text was updated successfully, but these errors were encountered: