Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bisect behat #118

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Bisect behat #118

merged 3 commits into from
Apr 15, 2024

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Apr 15, 2024

If GOOD_COMMIT and BAD_COMMIT are set, then a behat bisect happens between the 2 commits, using the exact configuration provided (tags, name, browser, database, ...)

Also, fix some edge case, specially with --tags or --name options, about better handle parameters having spaces or ampersands. Only when injecting the command into a shell script, not problem when executed inline (docker exec ...).

Covered with tests.

stronk7 added 2 commits April 15, 2024 14:52
If GOOD_COMMIT and BAD_COMMIT are set, then a behat
bisect happens between the 2 commits, using the exact
configuration provided (tags, name, browser, database, ...)
And, also, cover a couple of edge cases when
options (normally --tags and --name) have
white-spaces or ampersands.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.04478% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 63.90%. Comparing base (cd1a433) to head (74907d4).

Files Patch % Lines
runner/main/jobtypes/behat/behat.sh 89.47% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   62.83%   63.90%   +1.07%     
==========================================
  Files          38       38              
  Lines        1348     1402      +54     
==========================================
+ Hits          847      896      +49     
- Misses        501      506       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7
Copy link
Member Author

stronk7 commented Apr 15, 2024

Self-merging this, so can launch some runs @ prod. Both local tests and GHA tell that we are ready! 🤞

@stronk7 stronk7 merged commit 826dc65 into moodlehq:main Apr 15, 2024
7 checks passed
@stronk7 stronk7 deleted the bisect_behat branch April 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants