Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DBTAG versions #135

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Conversation

junpataleta
Copy link
Contributor

Part of the 5.0 requirements issue: MDL-83470

Part of the 5.0 requirements issue: MDL-83470
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.84%. Comparing base (450e412) to head (a9b33b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   63.84%   63.84%           
=======================================
  Files          47       47           
  Lines        1643     1643           
=======================================
  Hits         1049     1049           
  Misses        594      594           
Flag Coverage Δ
behat_bisect_test 40.41% <50.00%> (ø)
behat_test 40.17% <50.00%> (ø)
phpunit_bisect_test 34.87% <50.00%> (ø)
phpunit_test 34.93% <75.00%> (ø)
postjobs_test 33.57% <50.00%> (ø)
runner_test 16.25% <25.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HuongNV13 HuongNV13 self-requested a review November 27, 2024 06:38
Part of the 5.0 requirements issue: MDL-83470
@HuongNV13
Copy link
Contributor

Hi @junpataleta,
I have pushed 2 commits to fix the failures
Commit 1
Remove skip-character-set-client-handshake. This was deprecated in MySQL 8.2 and removed in 8.4
Commit 2
Update tests to match the new PHP version

Could you please take a look on those commits?

@junpataleta
Copy link
Contributor Author

Thanks, @HuongNV13! Looks good!

@junpataleta junpataleta merged commit 54e8c82 into moodlehq:main Nov 28, 2024
13 checks passed
@junpataleta junpataleta deleted the 500_DB_requirements branch November 28, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants