-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows multi-touch support #1271
Comments
Yep, this is actually already implemented but disabled. The problem preventing us from shipping it on Android is that full native multi-touch interferes with the ability to launch the virtual keyboard using the 3-finger tap combo. We need to implement some kind of overlay or something to allow activation of the keyboard before we can turn it on. We should also probably add some type of zoom feature since touch targets can be very tiny on a phone/tablet screen. This wasn't an issue with the PC client because it never had virtual keyboard support. |
I'm curious: are there cases where android virtual keyboard got the upper hand over Windows one? On my use case, Windows touch keyboard would pop up even on UAC prompts (on moonlight-qt) and it has keybindings with Win/Ctrl/Shift. So, perhaps, it's for Linux? I really don't know |
This paragraph was translated. I think it is necessary to support multiple touch screens for operation on mobile phones. On the contrary, there are more keyboard calls, and I haven't found this feature after playing for half a month. If this affects the function, it would be more than worth the loss. My suggestion is to change the number of fingers exhaled, such as 5 fingers exhaling without affecting its function, or give users a chance to choose |
太难受了哇哥 |
hihihi |
Does it mean that multi-touch support has been already implemented, but has not been released yet? |
Yep, it’s in the code. You can compile it yourself and enable it
|
Now I understand why we use long press to achieve right click instead of double finger click,maybe we can use another why to adapt these needs, such as floating pop-up window. Altough multi-touch game is not common on PC, but I think cut off this function is a loss. RD client is a good teacher for us to learn from, two input mode can fit different demands. |
@cgutman I think that the three-finger gesture for bringing up the keyboard is not a good design choice, as seen in my XiaoMi Pad 5 Pro. It takes over all three-finger gestures: a long press with three takes a region screenshot, swiping down with three takes a screenshot, and swiping up with three opens the task manager. On its system, the keyboard invocation in your software becomes ineffective. Instead, sacrificing touch functionality to achieve this feature is unwise. Some games, such as Genshin Impact, require multi-touch gestures to play properly when touch UI is enabled through launch parameters. I suggest taking inspiration from the design of Microsoft RDP. Consider adding a toggle button and/or a separate button for bringing up the keyboard, and/or include some settings that allow users to choose from various gesture-based operations. I used machine translation. Below is the original text. |
want this feature on iOS moonlight pls |
I think adding a configure entry of touch screen in settings is feasible |
Why not add this as option? I mean I never used 3 fingers gesture to use Android keyboard but built in Windows keyboard instead. |
We already have the option to hold start button for mouse mode, why not hold select button for keyboard? Do people use Moonlight without a controller that often? Wouldn't they also have the controller overlay (and thus a select button on screen which they can tap and hold)? I feel not having native touch support is one of Moonlight's biggest downsides and is the only reason I still use SuperDisplay. The fact this feature is so within reach but not enabled is quite frustrating. It can surely be added as an option in settings? |
Yes, it can surely be an option and it would be quite easy to make a PR. |
You only need to remove /* and */ before compiling your own Moonlight build moonlight-android/app/src/main/java/com/limelight/Game.java Lines 2050 to 2057 in 6551076
|
Thanks for the info! I have since moved to a Chinese fork of the Moonlight client which includes native touch support as well as a handful of other features such as a full windows keyboard overlay and the ability to switch between touch/trackpad mode on the fly by using the back gesture on your phone to access a hidden menu. |
谢谢,我找到了~o(〃'▽'〃)o
…---Original---
From: ***@***.***>
Date: Tue, Mar 19, 2024 08:26 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [moonlight-stream/moonlight-android] Windows multi-touch support (Issue #1271)
You only need to remove /* and */ before compiling your own Moonlight build
Thanks for the info! I have since moved to a Chinese fork of the Moonlight client which includes native touch support as well as a handful of other features such as a full windows keyboard overlay and the ability to switch between touch/trackpad mode on the fly by using the back gesture on your phone to access a hidden menu.
Search for user 阿西西的日常 if interested.
IMG-20240317-WA0003.jpg (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Just created a fork myself to implement multi-touch on iOS. |
Thanks 🙏🏼 @cgutman maybe we can have this on an official release ? And the last really great thing would be to have different setting profiles, and to assign these profiles to games. Example: Greedy game like Avatar in 2k60. Lighter light game like God of war 4k120 And if we don't assign a profile to a game, it launches the stream with the profile |
Hi! Does this fork get rid of the "hold to right click" as well? |
Unfortunately no, it interfere with the windows native multitouch support, afaik this app only send touch event into the windows and the touch event is handled by windows. But, there is another way to disable "hold to right click" by using the regedit. Navigate to this entry, Please mind that this will disable the right click function of the touchscreen entirely (you need to re enable that registry again to enable the right click function) |
This is very good! |
It's possible, but not practical. direct mouse control almost the same as the windows native touch anyway. Unless there is a quick way to change touch control mode (like sidebar when back button pressed) |
Could you make a fork that forwards touch input instead of mouse input on mouse, trackpad, and touchpad devices? My skills aren't enough to figure it out. I'm experiencing this issue too, and I believe this might solve it. https://ideas.moonlight-stream.org/posts/41/support-samsung-s7-keyboard-cover-touchpad |
Well looks like i was wrong, there is no way to implement it if samsung is using they own API to implement touch event on the device. |
I’m using the latest Samsung Book Cover that was released about three months ago. Maybe the firmware has been updated? In most cases, including left-click and right-click, it behaves just like a mouse. However, when using two-finger scrolling, the keyboard uses drag instead of mouse wheel scrolling on the screen. So, even if I don’t know exactly how it’s processed, it seems that sending all inputs to Windows in touch mode would make it function correctly in all cases, including scrolling. If you watch the video I just posted (https://youtu.be/pMdNq2PGF28), you’ll understand. Click-and-drag actions require touch mode to work as scrolling. |
Is your feature request related to a problem? Please describe.
Current implementation on moonlight android involve specific hardcoded touch/gesture inputs for touchscreens (3 fingers for popping up Android keyboard eg.) but it will overwrite native Windows capabilities for touchscreens (scrolling, long press, pinch to zoom etc.)
Describe the solution you'd like
Add an option for preferring native multi-touch for supposed hosts (Windows)
Describe alternatives you've considered
Moonlight-qt is a perfect example for multi-touch support and I'd like to have the same implementation here on moonlight android
Screenshots
No response
The text was updated successfully, but these errors were encountered: