Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HtmlTable.Sort re-enable sort not setting spans again #1346

Open
boppy opened this issue Feb 3, 2017 · 0 comments
Open

HtmlTable.Sort re-enable sort not setting spans again #1346

boppy opened this issue Feb 3, 2017 · 0 comments

Comments

@boppy
Copy link
Contributor

boppy commented Feb 3, 2017 •
edited by arian
Loading

If you disable HtmlTable's sort and enable it again, the removed spans are not added again. So the GUI is likely to be broken after re-enable.

See https://jsfiddle.net/zachcdbn/

Will try to provide a fix this weekend.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@boppy boppy changed the title HtmlTable.Sort re-enable sort not working HtmlTable.Sort re-enable sort not setting spans again Feb 3, 2017
boppy pushed a commit to boppy/mootools-more that referenced this issue Feb 5, 2017
Fixes bug described in mootools#1346
390175b 
Sources out the creation of the sort-span tag in order to re-inject them
on re-enable sorting.
@boppy boppy mentioned this issue Feb 5, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boppy