Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Accept request and choose ID button in sharing screen should be changed to Accept request and share #365

Closed
santhoshsunder opened this issue Dec 23, 2022 · 3 comments
Assignees
Labels
beta_must_fix bug Something isn't working Minor triaged Triage completed
Milestone

Comments

@santhoshsunder
Copy link
Contributor

Describe the bug
Accept request and choose ID button in sharing screen should be changed to Accept request and share

prerequisite: Vc is downloaded and stored in the app
Device A : Requesting
Device B : Sharing

To Reproduce

  1. unlock the app
  2. Open qrcode in Device A
  3. Open scanner in Device B
  4. scan qrcode from Device B
  5. Select VC in sharing screen

Current behavior
Select VC and see that "Accept request and choose ID " button is enabled . As we VC is selected already the word Choose ID in the button is not giving the right meaning rather it is making user to assume that VC should be selected in Next step which we selected already.

Expected behavior
Accept request and choose ID button in sharing screen should be changed to Accept request and share

Screenshots
image

Smartphone :

@santhoshsunder santhoshsunder added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet Minor labels Dec 23, 2022
@Sujithbn Sujithbn added triaged Triage completed beta_must_fix and removed triage This issue is pending confirmation and planning and should not be worked on yet labels Jan 24, 2023
@Sujithbn Sujithbn assigned MonobikashDas and unassigned Sujithbn Jan 24, 2023
@adityankannan-tw
Copy link
Contributor

adityankannan-tw commented Mar 21, 2023

This issue is not valid as new label changes are requested and picked up and merged as part of 28-02-2023 release in issue - #589.

The new changes are,
--> "Accept request and choose ID" to "Share".
--> "Accept request and verify" to "Share with Selfie".

@ravikp ravikp moved this to QA (test) in MOSIP Inji issues tracking Mar 21, 2023
@ravikp ravikp modified the milestones: 24th MAR, 15th MAR 23 Mar 21, 2023
@ravikp
Copy link
Contributor

ravikp commented Mar 21, 2023

@santhoshsunder - Re-assigning it to you, as this defect isn't applicable you are free to close.

@santhoshsunder
Copy link
Contributor Author

The issue is not applicable in the new build, the button has been removed, hence closing the bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta_must_fix bug Something isn't working Minor triaged Triage completed
Projects
Status: Merged
Development

No branches or pull requests

5 participants