Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android - We are able to activate received VCs #512

Closed
santhoshsunder opened this issue Jan 30, 2023 · 6 comments
Closed

Android - We are able to activate received VCs #512

santhoshsunder opened this issue Jan 30, 2023 · 6 comments
Assignees
@santhoshsunder
Labels
BLE BLE Transefer of VCs bug Something isn't working Critical good first issue Good for newcomers MEC targeted for MEC triaged Triage completed
Milestone
28th Feb 23

Comments

@santhoshsunder
Copy link
Contributor

Describe the bug
We are able to activate received VCs and login through IDP with received VCs

To Reproduce
Prerequiste: download a VC and dont bind, receive a VC

  1. Authenticate the app and enter it
  2. Go to received id section, click on the received IDs
  3. select the received VC and bind it
  4. click on the scan page, and scan the idp portal
  5. manually verify the site and click on continue

Expected behavior
We should not able to bind received VCs and should not able to login with it

Observed
we are able to bind received VCs and able to login with it

Video
https://user-images.githubusercontent.com/102220709/215513078-120ff9c3-a011-4c4d-8f39-b4a061d6df53.mp4

Smartphone :
@santhoshsunder santhoshsunder added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet Critical BLE BLE Transefer of VCs labels Jan 30, 2023
@Sujithbn Sujithbn added triaged Triage completed and removed triage This issue is pending confirmation and planning and should not be worked on yet labels Jan 31, 2023
@Sujithbn Sujithbn assigned MonobikashDas and unassigned Sujithbn Jan 31, 2023
@MonobikashDas
Copy link
Contributor

As discussed, you have raised another bug for which we will not provide binding option . Hence this is not a valid bug,

@rakhimosip rakhimosip self-assigned this Jan 31, 2023
@rakhimosip
Copy link
Contributor

We will be creating a separate Verifier app. Hence any verifier-related bugs/issues will not be considered a priority for Beta release. Will be picked up only after addressing all blockers and critical bugs if capacity is available with the team.

CC @Sujithbn @MonobikashDas @Raginikrishnamurthy @Anushree09-N @santhoshsunder @ravikp

@Sujithbn Sujithbn added the MEC targeted for MEC label Feb 24, 2023
@ravikp ravikp added the good first issue Good for newcomers label Feb 24, 2023
@Sujithbn Sujithbn assigned ravikp and unassigned rakhimosip and MonobikashDas Feb 24, 2023
PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Feb 27, 2023
@PuBHARGAVI
refactor(mosip#512): [Vijay|Bhargavi] remove activation button onrece…
b6936f4 
…ived id's tab
PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Feb 27, 2023
@PuBHARGAVI
refactor(mosip#512): [Bhargavi] removed activation status for vc's in…
32cb6b4 
… received id's tab
PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Feb 27, 2023
@PuBHARGAVI
refactor(mosip#512): [Bhargavi] removed activation status of VC in in…
178bd1d 
…coming id screen
ravikp added a commit to tw-mosip/inji-wallet that referenced this issue Feb 28, 2023
@ravikp
Merge pull request #5 from ravikp/remove-activate-button-in-received-id
9ef3d5f 
refactor(mosip#512): [Vijay|Bhargavi] remove activation button for vc on received Id's tab
@PuBHARGAVI
Copy link
Contributor

PuBHARGAVI commented Feb 28, 2023 •
edited
Loading

Removed Activation status info of VC on the receiver side:
Removed it in received Id's Tab:
Screenshot 2023-02-28 at 10 51 55 AM
Removed in detailed view of VC on receiver side:
Screenshot 2023-02-28 at 10 57 43 AM
Removed in Incoming VC screen:
Screenshot 2023-02-27 at 11 21 54 PM

@PuBHARGAVI PuBHARGAVI mentioned this issue Feb 28, 2023
Closed
@tilak-puli tilak-puli mentioned this issue Feb 28, 2023
Merged
ravikp added a commit that referenced this issue Feb 28, 2023
@ravikp
Merge pull request #595 from ravikp/develop
452bc3e 
Include Feb/28/2023 release - Inji Changes

* Change VC button labels #589 
* Auto select first VC #590 
* Remove activate button for received VC's #512
@ravikp
Copy link
Contributor

ravikp commented Feb 28, 2023

Issue merged in the PR - #595

@Sujithbn Sujithbn added this to the 28th Feb 23 milestone Feb 28, 2023
@ravikp ravikp moved this to Development in MOSIP Inji issues tracking Feb 28, 2023
@Sujithbn Sujithbn moved this from Development to QA (test) in MOSIP Inji issues tracking Feb 28, 2023
@Alka1703
Copy link
Contributor

The following PRs implements restrictions for verifier to not activate the received VC and do any actions on it.
PR for mosip/tuvali: mosip/tuvali#28
PR for mosip/inji: #595, #597

The PRs have been merged in 28-02-2023 Release and the latest commit id on mosip/inji/develop is 7cdee82

@damodarguru
Copy link

damodarguru commented Mar 15, 2023 •
edited
Loading

Verified this issue in qa-1201-b2 environment, now removed Activation status info of VC on the receiver side, so we can not bind received VCs and should not be able to login with it. I am attaching the video and the device details below for reference. Hence closing the bug.
Video: -

Untitled.1.mp4

image

Tested in: -
Device: Redmi 7A
Android Version: 10
BLE version :4.2
Inji app link: https://github.com/mosip/inji/actions/runs/4376897206
Mimoto version: 1.2.0.1
MOSIP Version: qa-1201-b2.mosip.net

@github-project-automation github-project-automation bot moved this from QA (test) to Merged in MOSIP Inji issues tracking Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@santhoshsunder santhoshsunder

Labels
BLE BLE Transefer of VCs bug Something isn't working Critical good first issue Good for newcomers MEC targeted for MEC triaged Triage completed
Projects
MOSIP Inji issues tracking
Status: Merged
Milestone
28th Feb 23
Development

No branches or pull requests
10 participants
@ravikp @krishnakumar4a4 @Alka1703 @MonobikashDas @PuBHARGAVI @rakhimosip @Raginikrishnamurthy @santhoshsunder @Sujithbn @damodarguru