Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the credential selection process during credential share #590

Closed
nayakrounak opened this issue Feb 27, 2023 · 6 comments
Closed

Modify the credential selection process during credential share #590

nayakrounak opened this issue Feb 27, 2023 · 6 comments
Assignees
@Sujithbn
Labels
enhancement New feature or request good first issue Good for newcomers MEC targeted for MEC task Non functional tasks triage This issue is pending confirmation and planning and should not be worked on yet
Milestone
28th Feb 23

Comments

@nayakrounak
Copy link

Describe the bug
The credential selection process needs to change during credential share.

  • The first credential should be auto selected
  • The selected credential should be highlighted in green (colour may change based on theme)
  • The radio button from the credentials should be removed

Pre-requisite
The application should have at least one credential to share.

To Reproduce
Steps to reproduce the behaviour:

  1. Open the application
  2. Click on the QR code scanner
  3. Scan the verifier QR code to connect with the verifier application
  4. Share credential screen is shown below

Expected behaviour

  • The first credential should be auto selected
  • The selected credential should be highlighted in green (colour may change based on theme)
  • The radio button from the credentials should be removed

Screenshots

image

Smartphone (please complete the following information):
Not Applicable

Additional context
Enhancement as discussed with Sasi on 24th Feb 2023.
@nayakrounak nayakrounak added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet labels Feb 27, 2023
@Sujithbn Sujithbn added the MEC targeted for MEC label Feb 27, 2023
@Sujithbn Sujithbn added task Non functional tasks good first issue Good for newcomers and removed bug Something isn't working labels Feb 27, 2023
@nayakrounak
Copy link
Author

Hi @ravikp ,

For this ticket.

We need the auto-selection of the first credential to be fixed by Tomorrow.

The modification for highlighting the selected credential and removal of the radio button can come in later versions of the app.

@ravikp ravikp moved this to Analysis in MOSIP Inji issues tracking Feb 27, 2023
@ravikp ravikp added the enhancement New feature or request label Feb 27, 2023
tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Feb 28, 2023
@tilak-puli
feat(mosip#590): Add gaurd to autoselect vc logic to handle no vc case
19d1434
ravikp added a commit to tw-mosip/inji-wallet that referenced this issue Feb 28, 2023
@ravikp
Merge pull request #6 from ravikp/auto-select-first-vc
92da78c 
feat(mosip#590): Add gaurd to autoselect vc logic to handle no vc case
@tilak-puli tilak-puli mentioned this issue Feb 28, 2023
Merged
ravikp added a commit that referenced this issue Feb 28, 2023
@ravikp
Merge pull request #595 from ravikp/develop
452bc3e 
Include Feb/28/2023 release - Inji Changes

* Change VC button labels #589 
* Auto select first VC #590 
* Remove activate button for received VC's #512
tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Feb 28, 2023
@tilak-puli
feat(mosip#590): fix first vc is getting re-selected once sharing is …
d7525d9 
…started
tilak-puli added a commit to tw-mosip/inji-wallet that referenced this issue Feb 28, 2023
@tilak-puli
Merge pull request #7 from ravikp/auto-select-first-vc
666384d 
feat(mosip#590): fix first vc is getting re-selected once sharing is started
@Sujithbn Sujithbn added this to the 28th Feb 23 milestone Feb 28, 2023
@Alka1703 Alka1703 mentioned this issue Feb 28, 2023
Merged
@Sujithbn Sujithbn moved this from Analysis to QA (test) in MOSIP Inji issues tracking Feb 28, 2023
@Alka1703
Copy link
Contributor

The following PRs implements auto selection of first VC on the consent page:
PR for mosip/tuvali: mosip/tuvali#28
PR for mosip/inji: #595, #597

The PRs have been merged in 28-02-2023 Release and the latest commit id on mosip/inji/develop is 7cdee82

adityankannan-tw pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 2, 2023
feat(mosip#590): [Adityan] change VC UI in share screen
cac5321
adityankannan-tw pushed a commit to tw-mosip/inji-wallet that referenced this issue Mar 3, 2023
refactor(mosip#590): [Adityan] change border width from 3 to 2
e72867d
@vharsh vharsh mentioned this issue Mar 6, 2023
Merged
@vharsh
Copy link
Member

vharsh commented Mar 6, 2023 •
edited by krishnakumar4a4
Loading

In the last release (28th Feb), we have addressed only

  • The first credential should be auto selected

As part of the current release (6th Mar),
The following UI enhancement improves UX by highlighting the selected VC with green border and eliminates the radio button from the VCs on share-screen.

  • The selected credential should be highlighted in green (colour may change based on theme)
  • The radio button from the credentials should be removed

PR for mosip/tuvali: mosip/tuvali#29
PR for mosip/inji: #615

The PRs have been merged in 06-03-2023 Release and the latest commit id on mosip/inji/develop is 8867f3c

@vharsh
Copy link
Member

vharsh commented Mar 23, 2023

The selected credential should be highlighted in green (colour may change based on theme)

@krishnakumar4a4 Right now the agreed upon colour is green for the VC border let me know if a change has been requested for the same.

@Anuranjan14
Copy link

Anuranjan14 commented Mar 23, 2023 •
edited
Loading

The selected credential is getting highlighted in green for both orange and purple themes and radio button from VC is removed.
Attaching the screenshot for the reference.
image
CommitId:
image

@Anuranjan14 Anuranjan14 assigned Sujithbn and unassigned Anushree09-N Mar 23, 2023
@github-project-automation github-project-automation bot moved this from QA (test) to Merged in MOSIP Inji issues tracking Mar 24, 2023
@Kratitva
Copy link

This is fixed as part of release v0.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sujithbn Sujithbn

Labels
enhancement New feature or request good first issue Good for newcomers MEC targeted for MEC task Non functional tasks triage This issue is pending confirmation and planning and should not be worked on yet
Projects
MOSIP Inji issues tracking
Status: Merged
Milestone
28th Feb 23
Development

No branches or pull requests