Feature/comm 2233 clone api #38

ivanzusko · 2017-09-04T16:26:02Z

No description provided.

rafaeljesus · 2017-09-05T10:11:45Z

src/modules/pages/EditPage/EditApiForm.js

-    }),
+    state => {
+        const plugins = selector(state, 'plugins');
+


I'd remove this empty line

rafaeljesus · 2017-09-05T10:12:38Z

src/modules/pages/EditPage/EditApiForm.js

+        const lens = R.lensPath(['plugins']);
+        // substitude the plugin.config.limit
+        const updatedApi = R.set(lens, updatedPlugins, api);
+        // const x = api.plugins.map((item, index) => item.name === )


Just remove the commented code

rafaeljesus · 2017-09-05T10:15:02Z

src/modules/pages/EditPage/EditApiForm.js

+        return {
+            // initialValues: transformFormValues(state.apiReducer.api),
+            initialValues: transformFormValues(updatedApi),
+            // ***FOR SOME REASON NAME of the plugin DISCARDS while saving


// FIXME name of the plugin is discarded while saving

rafaeljesus · 2017-09-05T10:26:09Z

src/modules/pages/EditPage/EditApiForm.js

+    };
+    const getValues = key => initialValues.proxy[key];
+    const optionsTransformer = config => {
+        const opts = config.map(item => ({


maybe return first return config.map(item => ({})

rafaeljesus · 2017-09-05T10:27:08Z

src/modules/pages/EditPage/editApiContainer.js

    updateEndpoint,
 } from '../../../store/actions';

 import ApiItem from './ApiItem';

 const mapStateToProps = state => ({
    api: state.apiReducer.api,
+    selectedPlugins: state.apiReducer.selectedPlugins,
+    // selectedPlugins: state.apiReducer.api.plugins.map(item => item.name),


I'd remove commented code

this is my personal Dragon I'm fighting with 🐉

rafaeljesus · 2017-09-05T10:33:05Z

src/modules/pages/NewApiPage/NewApiForm.js

        plugins,
        excludePlugin,
        selectPlugin,
        selectedPlugins,
    } = props;
+    console.error('NEW API', props);
    const parse = value => (value === undefined ? undefined : parseInt(value));


const parse = value => value && parseInt(value);

Damn... you are right! Don't understand why I did do that by myself 😞

rafaeljesus · 2017-09-05T10:34:38Z

src/modules/pages/NewApiPage/NewApiItem.js

@@ -22,14 +24,20 @@ const propTypes = {
 class NewApiItem extends Component {
    componentWillMount() {
        this.props.resetEndpoint();
+        console.error('------', this.props.location.pathname);


curious why logging error here?

rafaeljesus · 2017-09-05T10:46:53Z

src/modules/pages/NewApiPage/NewApiItem.js

+    renderForm = () => {
+        if (this.hasToBeCloned()) {
+            if (!R.isEmpty(this.props.api)) {
+                console.error('go to EDIT =>c ', this.props);


console.error

rafaeljesus · 2017-09-05T10:58:35Z

src/store/actions/api.actions.js

-            console.log('FETCH_ENDPOINT_ERROR', 'Infernal server error', error);
+    try {
+        const response = await client.get(`apis${pathname}`);
+        const preparedPlugins = response.data.plugins.map(plugin => {


If this function is the same of the above in willClone method just extract this ad reuse it in both places

almost, but has some differences. I'll try to find the way to extract the common part in separate PR

rafaeljesus · 2017-09-05T11:02:10Z

src/store/actions/api.actions.js

+    const preparedApi = R.set(R.lensPath(['plugins']), preparedPlugins, api);
+
+    // return client.post('apis', api)
+    return client.post('apis', preparedApi)


here you could make use of async/await

try { apis = await client.post('apis', preparedApi) dispatch(....) } catch (e) { switch true { case error.response: case error.request: default: } }

rafaeljesus · 2017-09-05T11:02:48Z

src/store/actions/api.actions.js

-    })
-    .catch((error) => {
-        if (error.response) {
+    return client.put(`apis${pathname}`, preparedApi)


async/await here too

Yeap, @rafaeljesus , this is done is separate PR#39

rafaeljesus · 2017-09-05T11:04:17Z

src/store/actions/api.actions.js

+
+            return R.set(lens3, getSelectedPolicy(plugin.config.policy), pluginWithPolicyFromSchema);
+        }
+        if (plugin.name === 'request_transformer') {


Maybe we could use a switch statement

Yeap, I'll do this in a separate PR in which I will also try to extract the common parts. This one is already too big 😷

rafaeljesus · 2017-09-05T11:14:26Z

src/configurations/apiSchema.js

+                            value: 'local',
+                        },
+                        {
+                            label: 'destributed',


typo distributed

Genau, @rafaeljesus ... 😞

rafaeljesus · 2017-09-05T11:18:22Z

src/store/actions/api.actions.js

+    try {
+        const response = await client.get(`apis${pathname}`);
+        const preparedPlugins = response.data.plugins.map(plugin => {
+            if (plugin.name === 'rate_limit') {


switch case here too

Yeap, I'll do this in a separate PR in which I will also try to extract the common parts. This one is already too big 😷

rafaeljesus · 2017-09-05T11:20:18Z

src/store/actions/api.actions.js

-        }
-    });
-};
+export const preparePlugins = api => api.plugins.map(plugin => {


This function should not be public/exported right? Only for internal usage

it's exporting for future. to make it tested by Jest.

But I've got your point => it should be extracted to separate file and tested there, but not here.

Caraca! 🇧🇷

Just as reminder for myself: issue#40

rafaeljesus · 2017-09-05T11:20:48Z

src/store/actions/api.actions.js

+    // substitude updated list of plugins
+    const preparedApi = R.set(R.lensPath(['plugins']), preparedPlugins, api);
+
+    return client.put(`apis${pathname}`, preparedApi)


async/await too

⏫ it's done and is waiting for you here, @rafaeljesus : #39

Ah perfect I will review after lunch then 👍

rafaeljesus · 2017-09-05T11:28:58Z

Don't for get to create a Jira Ticket or something for doing the improvements we've pointed out bitte

rafaeljesus · 2017-09-05T11:29:02Z

👍

ivanzusko added 30 commits August 18, 2017 17:30

add new delete button and icon

38ca323

chore(fix): button styles;

a963313

change structure

696cb42

restructure and add top part of the page

59013bc

--amend

9aef2f7

fix scss variables imports

68ddfd2

General and Proxy save correctly, but issues with initial render

65071e9

change custom check isEmpty on ramda's one

05df869

fix radios rendering

cf7dc43

add health check section(3)

2ddc001

add Plugins section, but needs logic revision

6919b39

add lost className

83e332f

save button upd

0442594

fix buttons alignment

b2511c0

fix rate_limit

ba24186

--amend

1996d09

render intitial proxy correctly depends on new or edit page

297a7de

add and edit finally partialy works fine

2bff39c

fix cors rendering in edit mode

5180e5d

merge fresh master

7f318b8

yet another update

1ea78d6

pause

41fc3ab

cors, oAuth, compression done

7163f91

add todo

0ca17b8

merge fresh master

af034df

merge fresh master

a7c248f

all plugins except of request_transformer work in New and Edit

bc8252a

add, edit done. need clone

7f68217

copy work except of plugins

00ae6d0

adjust clone logic to new structure

bdbf1d7

rafaeljesus reviewed Sep 5, 2017

View reviewed changes

remove redundant stuff

004b7c9

rafaeljesus reviewed Sep 5, 2017

View reviewed changes

remove redundant stuff

0ebb115

rafaeljesus reviewed Sep 5, 2017

View reviewed changes

ivanzusko added 2 commits September 5, 2017 12:50

remove redundant stuff

0f1828c

readability

0901885

rafaeljesus reviewed Sep 5, 2017

View reviewed changes

ivanzusko added 2 commits September 5, 2017 13:06

DRY

cee359e

remove redundant stuff

1ede3fa

rafaeljesus reviewed Sep 5, 2017

View reviewed changes

ivanzusko added 2 commits September 5, 2017 13:33

remove redundant stuff

549c6ed

remove redundant stuff

85715c1

rafaeljesus approved these changes Sep 5, 2017

View reviewed changes

merge fresh master

c76016d

ivanzusko merged commit cc56e99 into master Sep 5, 2017

ivanzusko deleted the feature/COMM-2233__clone-api branch September 5, 2017 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/comm 2233 clone api #38

Feature/comm 2233 clone api #38

ivanzusko commented Sep 4, 2017

rafaeljesus Sep 5, 2017

rafaeljesus Sep 5, 2017

rafaeljesus Sep 5, 2017

rafaeljesus Sep 5, 2017

rafaeljesus Sep 5, 2017

ivanzusko Sep 5, 2017

rafaeljesus Sep 5, 2017

ivanzusko Sep 5, 2017

rafaeljesus Sep 5, 2017

rafaeljesus Sep 5, 2017

rafaeljesus Sep 5, 2017

ivanzusko Sep 5, 2017

rafaeljesus Sep 5, 2017

rafaeljesus Sep 5, 2017

ivanzusko Sep 5, 2017

rafaeljesus Sep 5, 2017

ivanzusko Sep 5, 2017

rafaeljesus Sep 5, 2017

ivanzusko Sep 5, 2017

rafaeljesus Sep 5, 2017

ivanzusko Sep 5, 2017

rafaeljesus Sep 5, 2017

ivanzusko Sep 5, 2017 •

edited

Loading

ivanzusko Sep 5, 2017

rafaeljesus Sep 5, 2017

ivanzusko Sep 5, 2017

rafaeljesus Sep 5, 2017

ivanzusko Sep 5, 2017

rafaeljesus commented Sep 5, 2017

rafaeljesus commented Sep 5, 2017

Feature/comm 2233 clone api #38

Feature/comm 2233 clone api #38

Conversation

ivanzusko commented Sep 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivanzusko Sep 5, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaeljesus commented Sep 5, 2017

rafaeljesus commented Sep 5, 2017

ivanzusko Sep 5, 2017 •

edited

Loading