From 6d224a79385e55bb4e818bb8e37858bcd8a10f01 Mon Sep 17 00:00:00 2001
From: Corma Martinez del Rio <66973815+cmdelrio@users.noreply.github.com>
Date: Tue, 26 Sep 2023 14:41:07 -0600
Subject: [PATCH] Fix more linting issues
---
parsons/mobilecommons/mobilecommons.py | 6 +-
.../mobilecommons_responses.py | 82 +++++++++----------
2 files changed, 43 insertions(+), 45 deletions(-)
diff --git a/parsons/mobilecommons/mobilecommons.py b/parsons/mobilecommons/mobilecommons.py
index f7b72af298..88d054ae50 100644
--- a/parsons/mobilecommons/mobilecommons.py
+++ b/parsons/mobilecommons/mobilecommons.py
@@ -11,7 +11,6 @@
from requests import HTTPError
import xmltodict
import logging
-import math
logger = logging.getLogger(__name__)
@@ -19,7 +18,6 @@
DATE_FMT = "%Y-%m-%d"
format_date = lambda x: parse_date(x).strftime(DATE_FMT) if x is not None else None
-
class MobileCommons:
"""
Instantiate the MobileCommons class.
@@ -343,8 +341,8 @@ def get_profiles(
Parsons table with requested broadcasts
"""
- custom_cols = "true" if include_custom_columns == True else "false"
- subscriptions = "true" if include_subscriptions == True else "false"
+ custom_cols = "true" if include_custom_columns else "false"
+ subscriptions = "true" if include_subscriptions else "false"
params = {
"phone_number": phones,
diff --git a/test/test_mobilecommons/mobilecommons_responses.py b/test/test_mobilecommons/mobilecommons_responses.py
index 4625b096ac..f9dd87c69e 100644
--- a/test/test_mobilecommons/mobilecommons_responses.py
+++ b/test/test_mobilecommons/mobilecommons_responses.py
@@ -42,18 +42,18 @@ class get_profiles_response:
-
- Cormac
+ Cormac
-
- Martinez del Rio
+ Martinez del Rio
@@ -61,16 +61,16 @@ class get_profiles_response:
-
@@ -112,7 +112,7 @@ class get_broadcasts_response:
Test 6/6 DD DH
- Hey {{first_name}}!! On a scale of 1-5, how is your day going?
+ Hey {{first_name}}!! On a scale of 1-5, how is your day going?
Reply STOP to quit. Msg&DataRatesMayApply
TEST DH DD
@@ -135,7 +135,7 @@ class get_broadcasts_response:
Broadcast 04/10/2023 01:34PM test
- hi name, what's your email? Recurring Msgs. Reply STOP to quit, HELP for info.
+ hi name, what's your email? Recurring Msgs. Reply STOP to quit, HELP for info.
Msg&DataRatesMayApply
Dog King 2024
@@ -176,10 +176,10 @@ class post_profile_response:
2023-03-14 21:46:58 UTC2022-09-16 01:07:50 UTCOpt-out from API
-
@@ -210,17 +210,17 @@ class post_profile_response:
-
- Cormac
+ Cormac
-
- Martinez del Rio
+ Martinez del Rio
@@ -228,16 +228,16 @@ class post_profile_response:
-