Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Q: How to configure the goal_time_tolerance? #2390

Open
MatthijsBurgh opened this issue Sep 26, 2023 · 3 comments · May be fixed by #2580
Open

Q: How to configure the goal_time_tolerance? #2390

MatthijsBurgh opened this issue Sep 26, 2023 · 3 comments · May be fixed by #2580
Assignees
@Abishalini
Labels
bug Something isn't working persistent Allows issues to remain open without automatic stalling and closing.

Comments

@MatthijsBurgh
Copy link
Contributor

Is it possible to configure the goal_time_tolerance?

As the only code I have found which refers to it is:
https://github.com/ros-planning/moveit2/blob/c8a0eb0db885c4ee0c8c4e04304ec39e8d760f59/moveit_plugins/moveit_simple_controller_manager/src/follow_joint_trajectory_controller_handle.cpp#L108C7-L108C21
@MatthijsBurgh MatthijsBurgh added the bug Something isn't working label Sep 26, 2023
@sjahr
Copy link
Contributor

sjahr commented Oct 5, 2023

It does not look like it. This part probably needs to be refactored. The easiest way might be to expose this as a ROS 2 parameter

@github-actions GitHub Actions
Copy link

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Nov 20, 2023
@MatthijsBurgh
Copy link
Contributor Author

Maybe we need to add a label to this issue to prevent GH actions to close this issue.

@sjahr sjahr added persistent Allows issues to remain open without automatic stalling and closing. and removed stale Inactive issues and PRs are marked as stale and may be closed automatically. labels Nov 20, 2023
@Abishalini Abishalini linked a pull request Dec 6, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abishalini Abishalini

Labels
bug Something isn't working persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor MoveIt Simple Controller Manager to use generate param library Abishalini/moveit2
3 participants
@Abishalini @MatthijsBurgh @sjahr