Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support cost thresholding in STOMP #2658

Open
henningkayser opened this issue Jan 23, 2024 · 4 comments
Open

Properly support cost thresholding in STOMP #2658

henningkayser opened this issue Jan 23, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request persistent Allows issues to remain open without automatic stalling and closing.

Comments

@henningkayser
Copy link
Member

STOMP currently categorizes trajectories as invalid if they produce any penalty cost. This prevents us from optionally optimizing waypoints inside a valid constraint space, let's say for hitting position targets within tolerance or for maximizing clearance within acceptable limits. #2631 introduces a 0 cost for satisfied constraints to at least accept valid trajectories. A proper cost thresholding approach would instead still compute the cost, but set the validity flag depending on constraint tolerances.

@patrickKXMD
Copy link
Contributor

AFAIK there are two use cases for STOMP, one for optimizing the result from other planner, the other is standalone planner.

In my case I use standalone STOMP for all cartesian and joint space planning (not for optimizing the result from OMPL).
So any penalty cost in constraint space will result as a planning failed.

Maybe different cost counter for two cases?

@henningkayser henningkayser self-assigned this Feb 27, 2024
@henningkayser henningkayser moved this to 📋 Backlog in MoveIt Feb 27, 2024
Copy link

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Apr 12, 2024
@sjahr sjahr added persistent Allows issues to remain open without automatic stalling and closing. and removed stale Inactive issues and PRs are marked as stale and may be closed automatically. labels Apr 12, 2024
@patrickKXMD
Copy link
Contributor

@henningkayser
Hi, I'm a little worried for how to decide a proper cost threshold.

And I just looked up the code quickly, there is a config num_iterations_after_valid with default config 0.
If it is greater than 0, the STOMP planner it self will repeat iterations for that times and returns one solution with the lowest cost. So is this the right way if we want to continue optimizing?

What do you think?

@patrickKXMD
Copy link
Contributor

@henningkayser
Hi, any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Development

No branches or pull requests

3 participants