Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The readme doesn't provide enough examples #6

Open
sole opened this issue Jul 10, 2014 · 4 comments
Open

The readme doesn't provide enough examples #6

sole opened this issue Jul 10, 2014 · 4 comments
Assignees

Comments

@sole
Copy link

sole commented Jul 10, 2014

I had to go to the demo and then view the source and try to deduct how the component works because just 'using it' resulted in nothing being shown.

Idea: insist in the README that brick-layout needs some height to show something:

brick-layout {
  height: 100%;
}
@sole
Copy link
Author

sole commented Jul 10, 2014

Also the demo could use some interactivity too!

@sole
Copy link
Author

sole commented Jul 10, 2014

I got some more ideas playing with the demo in devtools.

Maybe you could make the CSS more dependant on the parent layout having the horizontal attribute, so the children nav and aside don't stay at 90px wide if the nested brick-layout is vertical.

You could maybe even use the flex reordering to lay them in a 'semantic' order in the HTML but show them in a different manner when rendered.

@dotch dotch self-assigned this Jul 19, 2014
@dotch
Copy link

dotch commented Jul 19, 2014

i started working on some demos for brick-layout.
have a look at:
http://mozbrick.github.io/examples/brick-layout/tabs.html
http://mozbrick.github.io/examples/brick-layout/drawer.html
and tell me what you think! :)
when I am done with the demos, I will update the readme.

@sole
Copy link
Author

sole commented Jul 21, 2014

Oh those demos are quite promising! Good work!
Some nitpicking:

  • they will look super spectacular if you add some CSS!
  • the drawer could automatically hide the drawer when you select an item-pressing M when in smaller viewport is a bit cumbersome
  • the way things are connected feels a bit too magic. brick-action? :-)
  • I don't quite find the horizontal-lt-... attributes very readable or intuitive but maybe once I see documentation I will. So far it's magic, like mentioned above!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants