Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to disable/configure the "indicator"? #21

Open
sole opened this issue Aug 8, 2014 · 6 comments
Open

Any way to disable/configure the "indicator"? #21

sole opened this issue Aug 8, 2014 · 6 comments
Labels

Comments

@sole
Copy link

sole commented Aug 8, 2014

I wanted to change the color and appearance of it and it confused me that it wasn't the bottom border of the selected tab, but a div that gets translated when the selected tab changes. Sure I can write a rule for brick-tabbar .selected-indicator but what I have ended up using is

brick-tabbar .selected-indicator {
  background-color: transparent;
}

in order to "disable" it.

I was thinking that perhaps Brick should be more neutral in that sense and make this either an optional feature or (harder to do) convert into a CSS rendering thing only rather than an element that is floating around.

Thoughts?

@sole sole added the question label Aug 8, 2014
@dotch
Copy link

dotch commented Aug 8, 2014

I really would like it to be a pure css thing in the theme, but I don't think the current animation would be doable.

so optionally disabling it via an attribute is probably a good way to go.

also people can build themes that simply do not style the indicator, because its styling is not part of the neutral basic stylesheet.

@sole
Copy link
Author

sole commented Aug 11, 2014

I had an idea: could you build the current animation using :before element with transitions? Probably the hardest issue would be determining the width of the element, though.

@dotch
Copy link

dotch commented Aug 11, 2014

Yes, I tried playing with the :before idea, but the problem really is determining the width..

@sole
Copy link
Author

sole commented Aug 11, 2014

If the elements are laid out with flex and have equal distributed width, could the :before elements use 100% of their parent? just wondering / throwing more ideas

@dotch
Copy link

dotch commented Aug 11, 2014

ah you are right, i remember, it was not the width, that was the problem, it was positioning the indicator at the selected item..

@potch
Copy link
Member

potch commented Aug 13, 2014

We should have a way to disable/hide the indicator, either via an attribute or if the WC spec still supports the crazy pseudoselector thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants