Skip to content
This repository has been archived by the owner on Feb 7, 2019. It is now read-only.

Code citations #269

Open
csuwildcat opened this issue Oct 2, 2014 · 0 comments
Open

Code citations #269

csuwildcat opened this issue Oct 2, 2014 · 0 comments

Comments

@csuwildcat
Copy link
Contributor

It's all open source, and I encourage the use of good code (even code that is claimed to have been ditched), but it would be nice to have a citation in the Brick readme and component files that use our stuff - for example: https://github.com/mozbrick/brick-flipbox/blob/master/src/brick-flipbox.js#L27-L40

Oh, and FYI: I glanced at the delegation function you're using. It looks like it would fail on selectors that require direct child matches, for instance:

If you delegate x-foo > .red on your x-foo custom element, it will fail to match these types of requirements, because QSA is evaluated from the x-foo element down, which cannot account for direct child relationships.

Hint: in X-Tag, you'll see a reference to matchesSelector in the delegation code ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant