Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

read.forwardRead and music.move conflict #1833

Open
ianb opened this issue Jul 22, 2020 · 1 comment
Open

read.forwardRead and music.move conflict #1833

ianb opened this issue Jul 22, 2020 · 1 comment

Comments

@ianb
Copy link
Contributor

ianb commented Jul 22, 2020

There's an error with npm run jest: "forward" now matches read.forwardRead instead of music.move.

I think we can actually adjust things so that the reader mode service responds to music.move, and remove this conflict along the way.

ianb added a commit that referenced this issue Jul 22, 2020
To actually fix the bug this should override the music.move implementation for the service, but this fixes the test at least
ianb added a commit that referenced this issue Jul 23, 2020
To actually fix the bug this should override the music.move implementation for the service, but this fixes the test at least
AbhiVaidya95 added a commit to AbhiVaidya95/firefox-voice that referenced this issue Jul 26, 2020
@AbhiVaidya95
Copy link
Contributor

@ianb Kindly ignore above commit I was trying to solve the issue.I didn't knew it was already taken care of. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants