Use new ldap export #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loud_users_driver/y18n-4.0.1' into use_new_ldap_export
Open
There was a problem hiding this comment.
I noted in SE-1879 that we should open a PR to remove elim-owner@ once we get that worked out.
pwnbus
commented
Jun 3, 2021
| if 'Not Authorized to access this resource/api' in str(error): | ||
| # We want to know about it, but still want to continue | ||
| # for users that we can't disable (admins) | ||
| logger.error("Unable to disable user: {}".format(email)) |
There was a problem hiding this comment.
I'm only producing a log entry for this error, but we may want to change this to be more obvious so we can setup cloudwatch alerts and know when our script hits these errors, as they require some sort of manual intervention.
pwnbus
commented
Jun 3, 2021
| CIS_S3_BUCKET_NAME: cache.ldap.sso.mozilla.com | ||
| CIS_LDAP_JSON_FILE: ldap_users.json.xz | ||
| LDAP_ASSUME_ROLE_ARN: arn:aws:iam::320464205386:role/cis-gsuite-users-driver | ||
| iam: |
There was a problem hiding this comment.
The newer version of serverless changed how some of these fields are stored, which is why I had to indent all these lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.