Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Felt privacy-Unified panel] - ETP toggle not displayed in the panel anymore after disabling it from settings #23306

Closed
data-sync-user opened this issue Nov 22, 2024 · 11 comments

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Nov 22, 2024

Steps to reproduce:

  1. Fresh install FF.
  2. Access a website. Tap on the lock icon to open the panel. ETP toggle in the panel is ON.
  3. Go to settings->tracking prot->disable the toggle.
  4. Return to the website and tap on the lock icon to open the panel.
  5. Observe

Actual results

ETP toggle is missing.

Expected results

ETP toggle is OFF

Device & build information

  • Device: iPad Air 11' (18.1)  iPhone 14 Pro Max (iOS 16.2)
  • Build version: v9000(47935)
  • First seen version: ?

┆Issue is synchronized with this Jira Bug

@data-sync-user
Copy link
Collaborator Author

➤ Diana Andreea Barladeanu commented:

Andres Furlan What’s your opinion on this? Is this a valid bug? Unfortunately, I am unable to find the exact info regarding this behavior so we’d need your input on this. Many thanks!

cc Alexandru Farcasanu

@data-sync-user
Copy link
Collaborator Author

➤ Andres Furlan commented:

Yes. It is missing the toggle. From the figma, I see that we are missing this:

!Screenshot 2025-01-17 at 10.23.31.png|width=337,height=724,alt="Screenshot 2025-01-17 at 10.23.31.png"!

@data-sync-user
Copy link
Collaborator Author

➤ Diana Andreea Barladeanu commented:

Andres Furlan after further investigating the current behavior, I would suggest that we should add a “Settings” link in the text string “Protections are OFF. We suggest turning them back on.” instead of the toggle . We don’t have a toggle in the current panel, either, once you turn off ETP from Settings, but you have the possibilty to turn ETP back ON by tapping on “Protection Settings” link. You should decide if you want to mirror the current behavior from this point of view. Please advise. Thanks!

@data-sync-user
Copy link
Collaborator Author

➤ Andres Furlan commented:

Alexandru Farcasanu lets add a hyperlink from the “Enhanced Tracking Protection” box to Settings (ETP). So the user has the ability to turn it on.

Nicole Weber what do you think about this case? I think we should improve the text inside explaining that is OFF for all sites.

@data-sync-user
Copy link
Collaborator Author

➤ Alexandru Farcasanu commented:

Andres Furlan how should look that hyperlink?

@data-sync-user
Copy link
Collaborator Author

➤ Nicole Weber commented:

Can someone remind me how to test it? I tried this:  You have to enable it in Settings > Tab on “Firefox 9000” 5x > Feature Flags > Enable New Tracking Protection but couldn’t find the feature flag. TY

@data-sync-user
Copy link
Collaborator Author

➤ Diana Andreea Barladeanu commented:

Hi Nicole Weber , after enabling the toggle from feature flags, you need to force close and reopen the app and you should see the new panel.

@data-sync-user
Copy link
Collaborator Author

➤ Nishant Bhasin commented:

I see two options here in case someone else has a better solution

a) When ETP is disabled for whole app we make the “Enhanced Tracking Protection - Off Section” fully tappable so it takes the user to privacy settings to enable ETP for the whole app.

b) When ETP is disabled for whole app we show a toggle inside “Enhanced Tracking Protection - Off Section” to enable to the whole app. This way user doesn’t need to go to the privacy settings and are protected.

cc Andres Furlan Nicole Weber

@data-sync-user
Copy link
Collaborator Author

➤ Alexandru Farcasanu commented:

Andres Furlan please, what option do you prefer from the Nishant Bhasin comment?

Option A can be easily implemented. Option B require a design (at least for me as a Dev).

One more thing, I need to know if we change the wording inside the Enhanced Tracking Protection section, if yes, I need the strings.

Thank you!

@data-sync-user
Copy link
Collaborator Author

➤ Andres Furlan commented:

Lets go with Option A

dicarobinho added a commit that referenced this issue Jan 29, 2025
…splayed in the panel anymore after disabling it from settings
dicarobinho added a commit that referenced this issue Jan 30, 2025
…splayed in the panel anymore after disabling it from settings (#24416)

* FXIOS-10650 #23306 ⁃ [Felt privacy-Unified panel] - ETP toggle not displayed in the panel anymore after disabling it from settings

* Renamed a parameter
@data-sync-user
Copy link
Collaborator Author

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v136 (50550), with iPhone 15 (17.6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant