Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10569 ⁃ [Menu] Fix the margin and Padding for the sections/islands in the menu. #23308

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Bugfix FXIOS-10569 ⁃ [Menu] Fix the margin and Padding for the sections/islands in the menu. #23308

merged 1 commit into from
Nov 22, 2024

Conversation

dicarobinho
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Fixed tableView margins and section headers height

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dicarobinho dicarobinho marked this pull request as ready for review November 22, 2024 10:27
@dicarobinho dicarobinho requested a review from a team as a code owner November 22, 2024 10:27
@dicarobinho dicarobinho added weekly-release Tagging backports for rapid release and removed weekly-release Tagging backports for rapid release labels Nov 22, 2024
@dicarobinho
Copy link
Collaborator Author

@Mergifyio backport release/v133

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2024 •
edited
Loading

backport release/v133

✅ Backports have been created

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.17%
📖 Edited 2 files
📖 Created 0 files

MenuKit: Coverage: 40.29

File Coverage
MenuMainView.swift 51.61% ✅
MenuTableView.swift 43.18% ⚠️

Generated by 🚫 Danger Swift against bef7a49

@dicarobinho dicarobinho merged commit 97d6161 into main Nov 22, 2024
12 of 13 checks passed
@dicarobinho dicarobinho deleted the afarcasanu/fxios_10569_23140_fix_the_margin_and_padding_for_the_sections branch November 22, 2024 10:53
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
@dicarobinho @mergify
Bugfix FXIOS-10569 ⁃ [Menu] Fix the margin and Padding for the sectio…
0b61555 
…ns/islands in the menu. (#23308)

FXIOS-10569 #23140 ⁃ [Menu Redesign] Fix the margin and Padding for the sections/islands in the menu.

(cherry picked from commit 97d6161)
@mergify mergify bot mentioned this pull request Nov 22, 2024
Open
6 tasks
clarmso pushed a commit that referenced this pull request Nov 25, 2024
@dicarobinho @clarmso
Bugfix FXIOS-10569 ⁃ [Menu] Fix the margin and Padding for the sectio…
2ea2250 
…ns/islands in the menu. (#23308)

FXIOS-10569 #23140 ⁃ [Menu Redesign] Fix the margin and Padding for the sections/islands in the menu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PARAIPAN9 PARAIPAN9 PARAIPAN9 approved these changes

@adudenamedruby adudenamedruby Awaiting requested review from adudenamedruby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dicarobinho @mobiletest-ci-bot @PARAIPAN9