Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pushmsix] Move app configuration out of init_worker.sh #1109

Open
hneiva opened this issue Dec 19, 2024 · 0 comments
Open

[pushmsix] Move app configuration out of init_worker.sh #1109

hneiva opened this issue Dec 19, 2024 · 0 comments

Comments

@hneiva
Copy link
Contributor

hneiva commented Dec 19, 2024

We currently manage app-specific settings, such as RELEASE_ROLLOUT_PERCENTAGE, BETA_APPLICATION_ID, and RELEASE_APPLICATION_ID, directly within the init_worker.sh file. As we introduce new applications, we continue adding more entries, deviating from the purpose of this file.

We should consider a different approach for handling these settings. Potential solutions include:

  • From Task Payload:
    Pass application-specific configurations through the task payload, keeping the logic inside pushmsix simpler, and making the requesting app more explicit on what's being pushed.

  • Constants/Configuration File:
    Store all app-specific constants in a dedicated configuration file (similar to existing patterns in beetmover, iscript, etc). This file would serve as a centralized reference point, making updates and additions easier.

Open Questions:

  • Which approach integrates best with our existing deployment and operational workflows?
  • Are there additional options/strategies for handling these settings?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant