From a4fe5db8575d8b55f9cc0f4ef3a08cf6d29c293f Mon Sep 17 00:00:00 2001 From: Jeff Hodges Date: Mon, 25 Nov 2024 10:17:46 -0800 Subject: [PATCH] add clarification to TestConcurrentEndEntityOperations The TestConcurrentEndEntityOperations is flaky. I suspect it's because we're not clearing the database between runs, but the test output is a lil unclear. --- database/queries_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/database/queries_test.go b/database/queries_test.go index 80a84de75..659e19e5e 100644 --- a/database/queries_test.go +++ b/database/queries_test.go @@ -74,7 +74,7 @@ func waitAndMakeEE(j int, db *Handler, wg *sync.WaitGroup, t *testing.T, signerI label, _, err = db.GetLabelOfLatestEE(signerID, 15*time.Second) switch err { case nil: - t.Logf("TestConcurrentEndEntityOperations: routine %d is returning end-entity %q", j, label) + t.Logf("TestConcurrentEndEntityOperations: routine %d is returning end-entity %q (after taking the transaction)", j, label) goto releaseLock case ErrNoSuitableEEFound: break @@ -95,7 +95,7 @@ func waitAndMakeEE(j int, db *Handler, wg *sync.WaitGroup, t *testing.T, signerI t.Fatalf("failed to end end-entity db operations: %v", err) } case nil: - t.Logf("TestConcurrentEndEntityOperations: routine %d is returning end-entity %q", j, label) + t.Logf("TestConcurrentEndEntityOperations: routine %d is returning end-entity %q (without taking the transaction)", j, label) default: t.Fatal(err) }