From 9ff8ccc471ab6c57cd3b196f2bd0dfa17973f21f Mon Sep 17 00:00:00 2001 From: Kevin Meinhardt Date: Wed, 20 Nov 2024 11:46:16 +0100 Subject: [PATCH] add missing test skeletons --- src/olympia/blocklist/tests/test_cron.py | 51 ++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/src/olympia/blocklist/tests/test_cron.py b/src/olympia/blocklist/tests/test_cron.py index 6febb5a25470..148679ae062e 100644 --- a/src/olympia/blocklist/tests/test_cron.py +++ b/src/olympia/blocklist/tests/test_cron.py @@ -462,6 +462,57 @@ def test_pass_correct_arguments_to_upload_filter(self): upload_stash=False, ) + def test_filter_updated_for_soft_blocked_when_switch_active(self): + """ + Test that the filter is updated for SOFT_BLOCKED block type when there are + sufficient changes and the 'enable-soft-blocking' switch is active. + """ + pass + + def test_stash_uploaded_for_soft_blocked_changes_when_below_threshold(self): + """ + Test that a stash is uploaded when there are changes in SOFT_BLOCKED items + below the threshold and the 'enable-soft-blocking' switch is active. + """ + pass + + def test_filters_updated_for_all_block_types(self): + """ + Test that filters are updated for both BLOCKED and SOFT_BLOCKED block types + when there are sufficient changes exceeding the threshold for both, and the + 'enable-soft-blocking' switch is active. + """ + pass + + def test_stash_uploaded_when_previous_filter_is_none(self): + """ + Test that a stash is generated and uploaded when there is no previous filter + and there are changes in blocks. + """ + pass + + def test_no_update_when_no_changes_in_blocks(self): + """ + Test that no update occurs and mlbf.delete() is called when there are + no changes in blocks for any block type. + """ + pass + + def test_filter_updated_for_blocked_when_soft_blocking_disabled(self): + """ + Test that the filter is updated for BLOCKED block type when there are + sufficient changes, even if the 'enable-soft-blocking' switch is inactive. + """ + pass + + def test_upload_filter_delay_called_with_correct_arguments(self): + """ + Test that upload_filter.delay is called with the correct filter_list and + upload_stash arguments when both base_filters_to_update and update_stash + are involved. + """ + pass + class TestTimeMethods(TestCase): @freeze_time('2024-10-10 12:34:56')