Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Notice component to be in-line with Photon spec and check its colours are correct. #11529

Closed
tofumatt opened this issue Mar 13, 2018 · 4 comments · Fixed by mozilla/addons-frontend#7146
Assignees
Labels
Milestone

Comments

@tofumatt
Copy link
Contributor

As mentioned in mozilla/addons-frontend#4548, it seems:

  1. Our Notice component needs style tweaks to be in-line with Photon
  2. The Photon styles are wrong re: "generic" colours for buttons (they say blue but look grey)
  3. We should allow Notice components to more easily render buttons that are links
  4. The fix for fix: Make "Download Firefox" notice less red addons-frontend#4548 should be changed to be a button link to "Download Firefox"
@kumar303
Copy link
Contributor

I asked for clarification in FirefoxUX/photon#287 . I'm pretty sure they should be gray.

@kumar303 kumar303 self-assigned this Nov 28, 2018
@kumar303 kumar303 added this to the 2018.12.13 milestone Nov 28, 2018
@kumar303
Copy link
Contributor

I'm like 99% sure these buttons should be gray so I'm making them gray. The blue button is too much of a call to action on the page.

@ioanarusiczki
Copy link

@kumar303 I checked on AMO dev (Win10) for the filter but I do not see it displayed as shown here mozilla/addons-frontend#7146

AMO dev

filter

@ioanarusiczki
Copy link

ioanarusiczki commented Dec 13, 2018

@kumar303 Ok, I figured out how the button becomes visible. The color is grey and it can be clicked.
It could be a darker grey (in my opinion) but while hovering it changes it's contrast.
Verified on AMO dev with FF63(Win10 & Android 8.0)

grey button

The Download Firefox button mentioned here is green but it's been like that for a while and the message from mozilla/addons-frontend#4548 was removed (that was for other browsers)

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants