Consider bypassing developer agreement check for langpacks upload

[diox]

https://bugzilla.mozilla.org/show_bug.cgi?id=1879549 happened because the developer agreement date changed on stage. Releng scripts that upload langpacks started to fail because their user had not accepted the agreement yet.

Their user is already part of a group giving them special rights. Should we have a special permission allowing them to bypass the developer agreement check entirely ?

┆Issue is synchronized with this Jira Task

[diox]

Related issues discovered on releng side as part of looking into this:

• addonscript: log http error response body mozilla-releng/scriptworker-scripts#913
• addonscript: don't retry on 4xx errors mozilla-releng/scriptworker-scripts#912

[wagnerand]

This sounds reasonable to me.

[diox]

I think the simplest solution is to give set bypass_upload_restrictions=True on their user(s) on all envs. No additional code changes needed, this was intended to allow bypassing all restrictions, including developer agreement.

[wagnerand]

I think the simplest solution is to give set bypass_upload_restrictions=True on their user(s) on all envs. No additional code changes needed, this was intended to allow bypassing all restrictions, including developer agreement.

I've done that now. One user had it already set, the other one didn't. I can't tell which one is the old user and which one is the new. Should we close this issue?

[diox]

Did you do it on stage as well ? (I think the user is [email protected])

[wagnerand]

Did you do it on stage as well ? (I think the user is [email protected])

I have now!

[KevinMind]

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-703