Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid establishing a shared secret for CTAP 2.0 authenticators when hmac-secret is not requested #341

Open
jschanck opened this issue Dec 12, 2024 · 0 comments

Comments

@jschanck
Copy link
Collaborator

jschanck commented Dec 12, 2024

In Bug 1936283 we have an example of an authenticator that returns a COSEKey with the wrong algorithm field in its GetKeyAgreement response. The authenticator has a built-in fingerprint reader, and does not support the getPinUvAuthTokenUsingUvWithPermissions function, so we should not need to establish a shared secret, however we establish one opportunistically in case we need to use the hmac-secret extension:

if info.supports_hmac_secret() {
let _shared_secret = dev.establish_shared_secret(alive)?;
}

We should avoid establishing a shared secret for CTAP 2.0 authenticators when hmac-secret is not explicitly requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant