-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event flows monitoring #4744
Merged
Merged
Event flows monitoring #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
scholtzan
force-pushed
the
event_flows_monitoring
branch
from
January 4, 2024 23:26
fb77776
to
9dc9d1e
Compare
This comment has been minimized.
This comment has been minimized.
4 tasks
scholtzan
commented
Jan 5, 2024
Comment on lines
+153
to
+187
MERGE | ||
`{{ project_id }}.{{ target_table }}` r | ||
USING | ||
event_flows f | ||
ON | ||
r.flow_id = f.flow_id | ||
-- look back up to 3 days to see if a flow has seen new events and needs to be replaced | ||
AND r.submission_date > DATE_SUB(@submission_date, INTERVAL 3 DAY) | ||
WHEN NOT MATCHED | ||
THEN | ||
INSERT | ||
(submission_date, flow_id, events, normalized_app_name, channel, flow_hash) | ||
VALUES | ||
(f.submission_date, f.flow_id, f.events, f.normalized_app_name, f.channel, f.flow_hash) | ||
WHEN NOT MATCHED BY SOURCE | ||
-- look back up to 3 days to see if a flow has seen new events and needs to be replaced | ||
AND r.submission_date > DATE_SUB(@submission_date, INTERVAL 3 DAY) | ||
THEN | ||
DELETE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a workaround for #4783
scholtzan
force-pushed
the
event_flows_monitoring
branch
from
January 9, 2024 17:46
9dc9d1e
to
35481c7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
akkomar
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc
sql_generators/glean_usage/templates/event_flow_monitoring_aggregates_v1.script.sql
Show resolved
Hide resolved
scholtzan
force-pushed
the
event_flows_monitoring
branch
from
January 9, 2024 21:57
3f6cb2a
to
8899272
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Integration report for "Merge branch 'main' into event_flows_monitoring"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):┆Issue is synchronized with this Jira Task