Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DO-1886): Add shredder mitigation for experiment tables #6533

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kwindau
Copy link
Contributor

@kwindau kwindau commented Nov 20, 2024

Description

This PR adds shredder mitigation to 3 SQL generator templates:

  • experiment_search_aggregates_v1
  • experiments_daily_active_clients_v1
  • experiment_enrollment_aggregates_v1

Related Tickets & Documents

Reviewer, please follow this checklist

┆Issue is synchronized with this Jira Task

@dataops-ci-bot
Copy link

Integration report for "Add experiment enrollment agg v1 to shredder mitigation"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/contextual_services/event_aggregates/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/contextual_services/event_aggregates/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/contextual_services/event_aggregates/schema.yaml	2024-11-20 02:20:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/contextual_services/event_aggregates/schema.yaml	2024-11-20 02:28:57.000000000 +0000
@@ -1,49 +1,49 @@
 fields:
-- mode: NULLABLE
-  name: submission_date
+- name: submission_date
   type: DATE
-- mode: NULLABLE
-  name: source
+  mode: NULLABLE
+- name: source
   type: STRING
-- mode: NULLABLE
-  name: event_type
+  mode: NULLABLE
+- name: event_type
   type: STRING
-- mode: NULLABLE
-  name: form_factor
+  mode: NULLABLE
+- name: form_factor
   type: STRING
-- mode: NULLABLE
-  name: country
+  mode: NULLABLE
+- name: country
   type: STRING
-- mode: NULLABLE
-  name: subdivision1
+  mode: NULLABLE
+- name: subdivision1
   type: STRING
-- mode: NULLABLE
-  name: advertiser
+  mode: NULLABLE
+- name: advertiser
   type: STRING
-- mode: NULLABLE
-  name: release_channel
+  mode: NULLABLE
+- name: release_channel
   type: STRING
-- mode: NULLABLE
-  name: position
+  mode: NULLABLE
+- name: position
   type: INTEGER
-- mode: NULLABLE
-  name: provider
+  mode: NULLABLE
+- name: provider
   type: STRING
-- mode: NULLABLE
-  name: match_type
+  mode: NULLABLE
+- name: match_type
   type: STRING
-- mode: NULLABLE
-  name: normalized_os
+  mode: NULLABLE
+- name: normalized_os
   type: STRING
-- mode: NULLABLE
-  name: suggest_data_sharing_enabled
+  mode: NULLABLE
+- name: suggest_data_sharing_enabled
   type: BOOLEAN
-- mode: NULLABLE
-  name: event_count
+  mode: NULLABLE
+- name: event_count
   type: INTEGER
-- mode: NULLABLE
-  name: user_count
+  mode: NULLABLE
+- name: user_count
   type: INTEGER
-- mode: NULLABLE
-  name: query_type
+  mode: NULLABLE
+- name: query_type
   type: STRING
+  mode: NULLABLE
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/contextual_services/event_aggregates_suggest/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/contextual_services/event_aggregates_suggest/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/contextual_services/event_aggregates_suggest/schema.yaml	2024-11-20 02:20:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/contextual_services/event_aggregates_suggest/schema.yaml	2024-11-20 02:29:11.000000000 +0000
@@ -1,40 +1,40 @@
 fields:
-- mode: NULLABLE
-  name: submission_date
+- name: submission_date
   type: DATE
-- mode: NULLABLE
-  name: form_factor
+  mode: NULLABLE
+- name: form_factor
   type: STRING
-- mode: NULLABLE
-  name: country
+  mode: NULLABLE
+- name: country
   type: STRING
-- mode: NULLABLE
-  name: advertiser
+  mode: NULLABLE
+- name: advertiser
   type: STRING
-- mode: NULLABLE
-  name: normalized_os
+  mode: NULLABLE
+- name: normalized_os
   type: STRING
-- mode: NULLABLE
-  name: release_channel
+  mode: NULLABLE
+- name: release_channel
   type: STRING
-- mode: NULLABLE
-  name: position
+  mode: NULLABLE
+- name: position
   type: INTEGER
-- mode: NULLABLE
-  name: provider
+  mode: NULLABLE
+- name: provider
   type: STRING
-- mode: NULLABLE
-  name: match_type
+  mode: NULLABLE
+- name: match_type
   type: STRING
-- mode: NULLABLE
-  name: suggest_data_sharing_enabled
+  mode: NULLABLE
+- name: suggest_data_sharing_enabled
   type: BOOLEAN
-- mode: NULLABLE
-  name: impression_count
+  mode: NULLABLE
+- name: impression_count
   type: INTEGER
-- mode: NULLABLE
-  name: click_count
+  mode: NULLABLE
+- name: click_count
   type: INTEGER
-- mode: NULLABLE
-  name: query_type
+  mode: NULLABLE
+- name: query_type
   type: STRING
+  mode: NULLABLE
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix/funnel_retention_clients/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix/funnel_retention_clients/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix/funnel_retention_clients/schema.yaml	2024-11-20 02:20:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix/funnel_retention_clients/schema.yaml	2024-11-20 02:29:20.000000000 +0000
@@ -26,6 +26,9 @@
 - name: adjust_network
   type: STRING
   mode: NULLABLE
+- name: install_source
+  type: STRING
+  mode: NULLABLE
 - name: retained_week_2
   type: BOOLEAN
   mode: NULLABLE
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix/funnel_retention_week_4/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix/funnel_retention_week_4/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/fenix/funnel_retention_week_4/schema.yaml	2024-11-20 02:20:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/fenix/funnel_retention_week_4/schema.yaml	2024-11-20 02:29:26.000000000 +0000
@@ -48,6 +48,10 @@
   description: 'The type of source of a client installation.
 
     '
+- name: install_source
+  type: STRING
+  mode: NULLABLE
+  description: null
 - name: new_profiles
   type: INTEGER
   mode: NULLABLE
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/ltv_states/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/ltv_states/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/ltv_states/schema.yaml	2024-11-20 02:20:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/ltv_states/schema.yaml	2024-11-20 02:29:01.000000000 +0000
@@ -1,64 +1,66 @@
 fields:
-- description: Unique ID for the client installation.
-  mode: NULLABLE
-  name: client_id
+- name: client_id
   type: STRING
-- description: Sample ID - A number ranging from 0 - 99 based on client ID; used to pull a small sample of data related to a subset of clients over time
   mode: NULLABLE
-  name: sample_id
-  type: INT64
-- description: Submission Date
+  description: Unique ID for the client installation.
+- name: sample_id
+  type: INTEGER
   mode: NULLABLE
-  name: submission_date
+  description: Sample ID - A number ranging from 0 - 99 based on client ID; used to
+    pull a small sample of data related to a subset of clients over time
+- name: submission_date
   type: DATE
-- description: First Seen Date - The date this client was first seen
   mode: NULLABLE
-  name: first_seen_date
+  description: Submission Date
+- name: first_seen_date
   type: DATE
-- description: Days Since First Seen - The number of days since the client was first seen
   mode: NULLABLE
-  name: days_since_first_seen
-  type: INT64
-- description: Days Since Active
+  description: First Seen Date - The date this client was first seen
+- name: days_since_first_seen
+  type: INTEGER
   mode: NULLABLE
-  name: days_since_active
-  type: INT64
-- description: First Reported Country - The country this client ID was first reported from
+  description: Days Since First Seen - The number of days since the client was first
+    seen
+- name: days_since_active
+  type: INTEGER
   mode: NULLABLE
-  name: first_reported_country
+  description: Days Since Active
+- name: first_reported_country
   type: STRING
-- description: Attribution
   mode: NULLABLE
-  name: attribution
+  description: First Reported Country - The country this client ID was first reported
+    from
+- name: attribution
   type: RECORD
+  mode: NULLABLE
   fields:
-  - mode: NULLABLE
-    name: source
+  - name: source
     type: STRING
+    mode: NULLABLE
     description: Attribution Source
-  - mode: NULLABLE
-    name: medium
+  - name: medium
     type: STRING
+    mode: NULLABLE
     description: Attribution Medium
-  - mode: NULLABLE
-    name: campaign
+  - name: campaign
     type: STRING
+    mode: NULLABLE
     description: Attribution Campaign
-  - mode: NULLABLE
-    name: content
+  - name: content
     type: STRING
+    mode: NULLABLE
     description: Attribution Content
-  - mode: NULLABLE
-    name: experiment
+  - name: experiment
     type: STRING
+    mode: NULLABLE
     description: Attribution Experiment
-  - mode: NULLABLE
-    name: variation
+  - name: variation
     type: STRING
+    mode: NULLABLE
     description: Attribution Variation
-  - mode: NULLABLE
-    name: dltoken
+  - name: dltoken
     type: STRING
+    mode: NULLABLE
     description: Attribution Download Token
   - name: dlsource
     type: STRING
@@ -68,40 +70,43 @@
     type: STRING
     mode: NULLABLE
     description: Attribution UA
-- description: Active
-  mode: NULLABLE
-  name: active
-  type: INT64
-- description: Ad Clicks - The number of ad clicks from this client on the submission date
+  description: Attribution
+- name: active
+  type: INTEGER
   mode: NULLABLE
-  name: ad_clicks
-  type: INT64
-- description: Total Historic Ad Clicks - The number of ad clicks from this client on or before the submission date
+  description: Active
+- name: ad_clicks
+  type: INTEGER
   mode: NULLABLE
-  name: total_historic_ad_clicks
-  type: INT64
-- description: Days Seen Bytes
+  description: Ad Clicks - The number of ad clicks from this client on the submission
+    date
+- name: total_historic_ad_clicks
+  type: INTEGER
   mode: NULLABLE
-  name: days_seen_bytes
+  description: Total Historic Ad Clicks - The number of ad clicks from this client
+    on or before the submission date
+- name: days_seen_bytes
   type: BYTES
-- description: Pattern
   mode: NULLABLE
-  name: pattern
+  description: Days Seen Bytes
+- name: pattern
   type: INTEGER
-- description: Death Time
   mode: NULLABLE
-  name: death_time
+  description: Pattern
+- name: death_time
   type: INTEGER
-- description: Max Days
   mode: NULLABLE
-  name: max_days
+  description: Death Time
+- name: max_days
   type: INTEGER
-- description: Markov States
   mode: NULLABLE
-  name: markov_states
+  description: Max Days
+- name: markov_states
   type: RECORD
-  fields:
-  - description: Desktop States V1
     mode: NULLABLE
-    name: desktop_states_v1
+  fields:
+  - name: desktop_states_v1
     type: STRING
+    mode: NULLABLE
+    description: Desktop States V1
+  description: Markov States
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/newtab_live/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/newtab_live/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/newtab_live/schema.yaml	2024-11-20 02:20:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_desktop/newtab_live/schema.yaml	2024-11-20 02:29:11.000000000 +0000
@@ -1,48 +1,47 @@
 fields:
-- description: Submission Timestamp
-  mode: NULLABLE
-  name: submission_timestamp
+- name: submission_timestamp
   type: TIMESTAMP
-- description: Normalized Country Code, Examples - US, AR, BR, etc.
   mode: NULLABLE
-  name: normalized_country_code
+  description: Submission Timestamp
+- name: normalized_country_code
   type: STRING
-- description: Normalized Channel, Examples - release, nightly, aurora, esr, beta
   mode: NULLABLE
-  name: normalized_channel
+  description: Normalized Country Code, Examples - US, AR, BR, etc.
+- name: normalized_channel
   type: STRING
-- description: Document ID
   mode: NULLABLE
-  name: document_id
+  description: Normalized Channel, Examples - release, nightly, aurora, esr, beta
+- name: document_id
   type: STRING
-- description: Pocket Enabled
   mode: NULLABLE
-  name: pocket_enabled
+  description: Document ID
+- name: pocket_enabled
   type: BOOLEAN
-- description: Pocket Sponsored Stories Enabled
   mode: NULLABLE
-  name: pocket_sponsored_stories_enabled
+  description: Pocket Enabled
+- name: pocket_sponsored_stories_enabled
   type: BOOLEAN
-- description: Newtab Locale
   mode: NULLABLE
-  name: newtab_locale
+  description: Pocket Sponsored Stories Enabled
+- name: newtab_locale
   type: STRING
-- description: App Build
   mode: NULLABLE
-  name: app_build
+  description: Newtab Locale
+- name: app_build
   type: STRING
-- description: App Display Version
   mode: NULLABLE
-  name: app_display_version
+  description: App Build
+- name: app_display_version
   type: STRING
-- description: Client ID
   mode: NULLABLE
-  name: client_id
+  description: App Display Version
+- name: client_id
   type: STRING
+  mode: NULLABLE
+  description: Client ID
 - name: events
   type: RECORD
   mode: REPEATED
-  description: Events
   fields:
   - name: category
     type: STRING
@@ -51,7 +50,6 @@
   - name: extra
     type: RECORD
     mode: REPEATED
-    description: Extras
     fields:
     - name: key
       type: STRING
@@ -61,6 +59,7 @@
       type: STRING
       mode: NULLABLE
       description: Value
+    description: Extras
   - name: name
     type: STRING
     mode: NULLABLE
@@ -69,3 +68,4 @@
     type: INTEGER
     mode: NULLABLE
     description: Event Timestamp
+  description: Events
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_search_console/limited_historical_search_impressions_by_page/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_search_console/limited_historical_search_impressions_by_page/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_search_console/limited_historical_search_impressions_by_page/schema.yaml	2024-11-20 02:20:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_search_console/limited_historical_search_impressions_by_page/schema.yaml	2024-11-20 02:29:05.000000000 +0000
@@ -6,9 +6,10 @@
 - name: site_url
   type: STRING
   mode: NULLABLE
-  description: |-
-    For domain properties, this will be `sc-domain:` followed by the domain name.
-    For URL-prefix properties, it will be the full URL of the property definition.
+  description: 'For domain properties, this will be `sc-domain:` followed by the domain
+    name.
+
+    For URL-prefix properties, it will be the full URL of the property definition.'
 - name: site_domain_name
   type: STRING
   mode: NULLABLE
@@ -28,19 +29,23 @@
 - name: localized_site_code
   type: STRING
   mode: NULLABLE
-  description: Localized site code such as `en-US` or `de` found in the first segment of the page URL path (if any).
+  description: Localized site code such as `en-US` or `de` found in the first segment
+    of the page URL path (if any).
 - name: localized_site
   type: STRING
   mode: NULLABLE
-  description: Description of the localized site language and/or country based on `localized_site_code` (if any).
+  description: Description of the localized site language and/or country based on
+    `localized_site_code` (if any).
 - name: localized_site_language_code
   type: STRING
   mode: NULLABLE
-  description: Localized site language code in ISO-639-alpha-2 format found in the first segment of the page URL path (if any).
+  description: Localized site language code in ISO-639-alpha-2 format found in the
+    first segment of the page URL path (if any).
 - name: localized_site_language
   type: STRING
   mode: NULLABLE
-  description: Localized site language based on `localized_site_language_code` (if any).
+  description: Localized site language based on `localized_site_language_code` (if
+    any).
 - name: query
   type: STRING
   mode: NULLABLE
@@ -48,20 +53,15 @@
 - name: query_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    Type of search query:
-      * Brand: Query contained one or more Mozilla brand keywords.
-      * Non-Brand: Query didn't contain any Mozilla brand keywords.
-      * Unknown: Query couldn't be classified.
+  description: "Type of search query:\n  * Brand: Query contained one or more Mozilla\
+    \ brand keywords.\n  * Non-Brand: Query didn't contain any Mozilla brand keywords.\n\
+    \  * Unknown: Query couldn't be classified."
 - name: search_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    Where the link was seen by the user:
-      * Web: In Google Search's default "All" tab.
-      * Image: In Google Search's "Images" tab.
-      * Video: In Google Search's "Videos" tab.
-      * News: In Google Search's "News" tab.
+  description: "Where the link was seen by the user:\n  * Web: In Google Search's\
+    \ default \"All\" tab.\n  * Image: In Google Search's \"Images\" tab.\n  * Video:\
+    \ In Google Search's \"Videos\" tab.\n  * News: In Google Search's \"News\" tab."
 - name: user_country_code
   type: STRING
   mode: NULLABLE
@@ -81,12 +81,13 @@
 - name: device_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    The type of device on which the user was searching: Desktop, Mobile, or Tablet.
+  description: 'The type of device on which the user was searching: Desktop, Mobile,
+    or Tablet.'
 - name: impressions
   type: INTEGER
   mode: NULLABLE
-  description: The number of times that search results with a link to the page were shown to a user.
+  description: The number of times that search results with a link to the page were
+    shown to a user.
 - name: clicks
   type: INTEGER
   mode: NULLABLE
@@ -94,4 +95,5 @@
 - name: average_position
   type: FLOAT
   mode: NULLABLE
-  description: The average position of the page in the search results, where `1` is the topmost position.
+  description: The average position of the page in the search results, where `1` is
+    the topmost position.
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_search_console/limited_historical_search_impressions_by_site/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_search_console/limited_historical_search_impressions_by_site/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_search_console/limited_historical_search_impressions_by_site/schema.yaml	2024-11-20 02:20:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_search_console/limited_historical_search_impressions_by_site/schema.yaml	2024-11-20 02:29:06.000000000 +0000
@@ -6,9 +6,10 @@
 - name: site_url
   type: STRING
   mode: NULLABLE
-  description: |-
-    For domain properties, this will be `sc-domain:` followed by the domain name.
-    For URL-prefix properties, it will be the full URL of the property definition.
+  description: 'For domain properties, this will be `sc-domain:` followed by the domain
+    name.
+
+    For URL-prefix properties, it will be the full URL of the property definition.'
 - name: site_domain_name
   type: STRING
   mode: NULLABLE
@@ -20,20 +21,15 @@
 - name: query_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    Type of search query:
-      * Brand: Query contained one or more Mozilla brand keywords.
-      * Non-Brand: Query didn't contain any Mozilla brand keywords.
-      * Unknown: Query couldn't be classified.
+  description: "Type of search query:\n  * Brand: Query contained one or more Mozilla\
+    \ brand keywords.\n  * Non-Brand: Query didn't contain any Mozilla brand keywords.\n\
+    \  * Unknown: Query couldn't be classified."
 - name: search_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    Where the link was seen by the user:
-      * Web: In Google Search's default "All" tab.
-      * Image: In Google Search's "Images" tab.
-      * Video: In Google Search's "Videos" tab.
-      * News: In Google Search's "News" tab.
+  description: "Where the link was seen by the user:\n  * Web: In Google Search's\
+    \ default \"All\" tab.\n  * Image: In Google Search's \"Images\" tab.\n  * Video:\
+    \ In Google Search's \"Videos\" tab.\n  * News: In Google Search's \"News\" tab."
 - name: user_country_code
   type: STRING
   mode: NULLABLE
@@ -53,17 +49,20 @@
 - name: device_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    The type of device on which the user was searching: Desktop, Mobile, or Tablet.
+  description: 'The type of device on which the user was searching: Desktop, Mobile,
+    or Tablet.'
 - name: impressions
   type: INTEGER
   mode: NULLABLE
-  description: The number of times that search results with at least one link to the site were shown to a user.
+  description: The number of times that search results with at least one link to the
+    site were shown to a user.
 - name: clicks
   type: INTEGER
   mode: NULLABLE
-  description: The number of times a user clicked at least one search result link to the site.
+  description: The number of times a user clicked at least one search result link
+    to the site.
 - name: average_top_position
   type: FLOAT
   mode: NULLABLE
-  description: The average top position of the site in the search results, where `1` is the topmost position.
+  description: The average top position of the site in the search results, where `1`
+    is the topmost position.
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_search_console/search_impressions_by_page/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_search_console/search_impressions_by_page/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_search_console/search_impressions_by_page/schema.yaml	2024-11-20 02:20:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_search_console/search_impressions_by_page/schema.yaml	2024-11-20 02:29:08.000000000 +0000
@@ -6,9 +6,10 @@
 - name: site_url
   type: STRING
   mode: NULLABLE
-  description: |-
-    For domain properties, this will be `sc-domain:` followed by the domain name.
-    For URL-prefix properties, it will be the full URL of the property definition.
+  description: 'For domain properties, this will be `sc-domain:` followed by the domain
+    name.
+
+    For URL-prefix properties, it will be the full URL of the property definition.'
 - name: site_domain_name
   type: STRING
   mode: NULLABLE
@@ -16,99 +17,104 @@
 - name: page_url
   type: STRING
   mode: NULLABLE
-  description: |-
-    The final page URL linked by a search result after any skip redirects.
-    This will be null for anonymized Discover impressions.
+  description: 'The final page URL linked by a search result after any skip redirects.
+
+    This will be null for anonymized Discover impressions.'
 - name: page_domain_name
   type: STRING
   mode: NULLABLE
-  description: |-
-    Domain name of the page URL.
-    This will be null for anonymized Discover impressions.
+  description: 'Domain name of the page URL.
+
+    This will be null for anonymized Discover impressions.'
 - name: page_path
   type: STRING
   mode: NULLABLE
-  description: |-
-    The path part of the page URL.
-    This will be null for anonymized Discover impressions.
+  description: 'The path part of the page URL.
+
+    This will be null for anonymized Discover impressions.'
 - name: localized_site_code
   type: STRING
   mode: NULLABLE
-  description: |-
-    Localized site code such as `en-US` or `de` found in the first segment of the page URL path (if any).
-    This will be null for anonymized Discover impressions.
+  description: 'Localized site code such as `en-US` or `de` found in the first segment
+    of the page URL path (if any).
+
+    This will be null for anonymized Discover impressions.'
 - name: localized_site
   type: STRING
   mode: NULLABLE
-  description: |-
-    Description of the localized site language and/or country based on `localized_site_code` (if any).
-    This will be null for anonymized Discover impressions.
+  description: 'Description of the localized site language and/or country based on
+    `localized_site_code` (if any).
+
+    This will be null for anonymized Discover impressions.'
 - name: localized_site_language_code
   type: STRING
   mode: NULLABLE
-  description: |-
-    Localized site language code in ISO-639-alpha-2 format found in the first segment of the page URL path (if any).
-    This will be null for anonymized Discover impressions.
+  description: 'Localized site language code in ISO-639-alpha-2 format found in the
+    first segment of the page URL path (if any).
+
+    This will be null for anonymized Discover impressions.'
 - name: localized_site_language
   type: STRING
   mode: NULLABLE
-  description: |-
-    Localized site language based on `localized_site_language_code` (if any).
-    This will be null for anonymized Discover impressions.
+  description: 'Localized site language based on `localized_site_language_code` (if
+    any).
+
+    This will be null for anonymized Discover impressions.'
 - name: query
   type: STRING
   mode: NULLABLE
-  description: |-
-    The search query.
-    This will be null for anonymized search impressions, and all Discover and Google News search impressions.
+  description: 'The search query.
+
+    This will be null for anonymized search impressions, and all Discover and Google
+    News search impressions.'
 - name: query_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    Type of search query:
-      * Anonymized: Query was redacted by Google to protect the users' privacy.
-      * Brand: Query contained one or more Mozilla brand keywords.
-      * Non-Brand: Query didn't contain any Mozilla brand keywords.
-      * Unknown: Query couldn't be classified.
-    This will be null for all Discover and Google News search impressions.
+  description: "Type of search query:\n  * Anonymized: Query was redacted by Google\
+    \ to protect the users' privacy.\n  * Brand: Query contained one or more Mozilla\
+    \ brand keywords.\n  * Non-Brand: Query didn't contain any Mozilla brand keywords.\n\
+    \  * Unknown: Query couldn't be classified.\nThis will be null for all Discover\
+    \ and Google News search impressions."
 - name: is_anonymized
   type: BOOLEAN
   mode: NULLABLE
-  description: |-
-    Whether Google has anonymized the search impression to protect the users' privacy.
+  description: 'Whether Google has anonymized the search impression to protect the
+    users'' privacy.
+
     The `query` field will be null for anonymized search impressions.
-    The `country_code`, `page_url`, and related fields will be null for anonymized Discover impressions.
+
+    The `country_code`, `page_url`, and related fields will be null for anonymized
+    Discover impressions.'
 - name: has_good_page_experience
   type: BOOLEAN
   mode: NULLABLE
-  description: Whether Google Search considers the page to be providing a good page experience.
+  description: Whether Google Search considers the page to be providing a good page
+    experience.
 - name: search_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    Where the link was seen by the user:
-      * Web: In Google Search's default "All" tab.
-      * Image: In Google Search's "Images" tab.
-      * Video: In Google Search's "Videos" tab.
-      * News: In Google Search's "News" tab.
-      * Discover: In Google's Discover feed.
-      * Google News: On news.google.com or in the Google News app on Android and iOS.
+  description: "Where the link was seen by the user:\n  * Web: In Google Search's\
+    \ default \"All\" tab.\n  * Image: In Google Search's \"Images\" tab.\n  * Video:\
+    \ In Google Search's \"Videos\" tab.\n  * News: In Google Search's \"News\" tab.\n\
+    \  * Discover: In Google's Discover feed.\n  * Google News: On news.google.com\
+    \ or in the Google News app on Android and iOS."
 - name: search_appearance
   type: STRING
   mode: NULLABLE
-  description: How the search result appeared (e.g. normal result, translated result, video).
+  description: How the search result appeared (e.g. normal result, translated result,
+    video).
 - name: user_country_code
   type: STRING
   mode: NULLABLE
-  description: |-
-    Country from which the user was searching, in ISO-3166-1-alpha-3 format.
-    This will be null for anonymized Discover impressions.
+  description: 'Country from which the user was searching, in ISO-3166-1-alpha-3 format.
+
+    This will be null for anonymized Discover impressions.'
 - name: user_country
   type: STRING
   mode: NULLABLE
-  description: |-
-    Country from which the user was searching.
-    This will be null for anonymized Discover impressions.
+  description: 'Country from which the user was searching.
+
+    This will be null for anonymized Discover impressions.'
 - name: user_region
   type: STRING
   mode: NULLABLE
@@ -120,13 +126,15 @@
 - name: device_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    The type of device on which the user was searching: Desktop, Mobile, or Tablet.
-    This will be null for Discover impressions.
+  description: 'The type of device on which the user was searching: Desktop, Mobile,
+    or Tablet.
+
+    This will be null for Discover impressions.'
 - name: impressions
   type: INTEGER
   mode: NULLABLE
-  description: The number of times that search results with a link to the page were shown to a user.
+  description: The number of times that search results with a link to the page were
+    shown to a user.
 - name: clicks
   type: INTEGER
   mode: NULLABLE
@@ -134,6 +142,7 @@
 - name: average_position
   type: FLOAT
   mode: NULLABLE
-  description: |-
-    The average position of the page in the search results, where `1` is the topmost position.
-    This will be null for Discover and Google News search impressions.
+  description: 'The average position of the page in the search results, where `1`
+    is the topmost position.
+
+    This will be null for Discover and Google News search impressions.'
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_search_console/search_impressions_by_site/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_search_console/search_impressions_by_site/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_search_console/search_impressions_by_site/schema.yaml	2024-11-20 02:20:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_search_console/search_impressions_by_site/schema.yaml	2024-11-20 02:29:04.000000000 +0000
@@ -6,9 +6,10 @@
 - name: site_url
   type: STRING
   mode: NULLABLE
-  description: |-
-    For domain properties, this will be `sc-domain:` followed by the domain name.
-    For URL-prefix properties, it will be the full URL of the property definition.
+  description: 'For domain properties, this will be `sc-domain:` followed by the domain
+    name.
+
+    For URL-prefix properties, it will be the full URL of the property definition.'
 - name: site_domain_name
   type: STRING
   mode: NULLABLE
@@ -20,27 +21,23 @@
 - name: query_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    Type of search query:
-      * Anonymized: Query was redacted by Google to protect the users' privacy.
-      * Brand: Query contained one or more Mozilla brand keywords.
-      * Non-Brand: Query didn't contain any Mozilla brand keywords.
-      * Unknown: Query couldn't be classified.
+  description: "Type of search query:\n  * Anonymized: Query was redacted by Google\
+    \ to protect the users' privacy.\n  * Brand: Query contained one or more Mozilla\
+    \ brand keywords.\n  * Non-Brand: Query didn't contain any Mozilla brand keywords.\n\
+    \  * Unknown: Query couldn't be classified."
 - name: is_anonymized
   type: BOOLEAN
   mode: NULLABLE
-  description: |-
-    Whether Google has anonymized the search impression to protect the users' privacy.
-    The `query` field will be null for anonymized search impressions.
+  description: 'Whether Google has anonymized the search impression to protect the
+    users'' privacy.
+
+    The `query` field will be null for anonymized search impressions.'
 - name: search_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    Where the link was seen by the user:
-      * Web: In Google Search's default "All" tab.
-      * Image: In Google Search's "Images" tab.
-      * Video: In Google Search's "Videos" tab.
-      * News: In Google Search's "News" tab.
+  description: "Where the link was seen by the user:\n  * Web: In Google Search's\
+    \ default \"All\" tab.\n  * Image: In Google Search's \"Images\" tab.\n  * Video:\
+    \ In Google Search's \"Videos\" tab.\n  * News: In Google Search's \"News\" tab."
 - name: user_country_code
   type: STRING
   mode: NULLABLE
@@ -60,17 +57,20 @@
 - name: device_type
   type: STRING
   mode: NULLABLE
-  description: |-
-    The type of device on which the user was searching: Desktop, Mobile, or Tablet.
+  description: 'The type of device on which the user was searching: Desktop, Mobile,
+    or Tablet.'
 - name: impressions
   type: INTEGER
   mode: NULLABLE
-  description: The number of times that search results with at least one link to the site were shown to a user.
+  description: The number of times that search results with at least one link to the
+    site were shown to a user.
 - name: clicks
   type: INTEGER
   mode: NULLABLE
-  description: The number of times a user clicked at least one search result link to the site.
+  description: The number of times a user clicked at least one search result link
+    to the site.
 - name: average_top_position
   type: FLOAT
   mode: NULLABLE
-  description: The average top position of the site in the search results, where `1` is the topmost position.
+  description: The average top position of the site in the search results, where `1`
+    is the topmost position.
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/klar_android/use_counters/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/klar_android/use_counters/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/klar_android/use_counters/schema.yaml	2024-11-20 02:20:59.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/klar_android/use_counters/schema.yaml	2024-11-20 02:30:51.000000000 +0000
@@ -1,11 +1,11 @@
 fields:
 - name: normalized_app_id
-  mode: NULLABLE
   type: STRING
+  mode: NULLABLE
   description: App ID of the channel data was received from
 - name: normalized_channel
-  mode: NULLABLE
   type: STRING
+  mode: NULLABLE
   description: Normalized channel name
 - name: additional_properties
   type: STRING
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_vpn/subscriptions/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_vpn/subscriptions/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_vpn/subscriptions/schema.yaml	2024-11-20 02:20:58.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_vpn/subscriptions/schema.yaml	2024-11-20 02:29:15.000000000 +0000
@@ -20,45 +20,3 @@
 - name: type
   type: STRING
   mode: NULLABLE
-- name: provider
-  type: STRING
-  mode: NULLABLE
-- name: apple_receipt
-  type: RECORD
-  mode: NULLABLE
-  fields:
-  - name: environment
-    type: STRING
-    mode: NULLABLE
-  - name: active_period
-    type: RECORD
-    mode: NULLABLE
-    fields:
-    - name: start_date
-      type: DATE
-      mode: NULLABLE
-    - name: end_date
-      type: DATE
-      mode: NULLABLE
-    - name: start_time
-      type: TIMESTAMP
-      mode: NULLABLE
-    - name: end_time
-      type: TIMESTAMP
-      mode: NULLABLE
-    - name: interval
-      type: STRING
-      mode: NULLABLE
-    - name: interval_count
-      type: INTEGER
-      mode: NULLABLE
-  - name: trial_period
-    type: RECORD
-    mode: NULLABLE
-    fields:
-    - name: start_time
-      type: TIMESTAMP
-      mode: NULLABLE
-    - name: end_time
-      type: TIMESTAMP
-      mode: NULLABLE
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/org_mozilla_fenix/geckoview_version/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/org_mozilla_fenix/geckoview_version/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/org_mozilla_fenix/geckoview_version/schema.yaml	2024-11-20 02:20:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/org_mozilla_fenix/geckoview_version/schema.yaml	2024-11-20 02:29:12.000000000 +0000
@@ -1,7 +1,13 @@
 fields:
-- type: DATETIME
-  name: build_hour
-- type: INTEGER
-  name: geckoview_major_version
-- type: INTEGER
-  name: n_pings
+- name: build_hour
+  type: DATETIME
+  mode: NULLABLE
+  description: null
+- name: geckoview_major_version
+  type: INTEGER
+  mode: NULLABLE
+  description: null
+- name: n_pings
+  type: INTEGER
+  mode: NULLABLE
+  description: null
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml	2024-11-20 02:20:59.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_daily/schema.yaml	2024-11-20 02:29:33.000000000 +0000
@@ -5,27 +5,21 @@
 - name: submission_date
   type: DATE
   mode: NULLABLE
-  description: null
 - name: client_id
   type: STRING
   mode: NULLABLE
-  description: null
 - name: aborts_content_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: aborts_gmplugin_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: aborts_plugin_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: active_addons_count_mean
   type: FLOAT
   mode: NULLABLE
-  description: null
 - name: active_addons
   type: RECORD
   mode: REPEATED
@@ -33,92 +27,69 @@
   - name: addon_id
     type: STRING
     mode: NULLABLE
-    description: null
   - name: blocklisted
     type: BOOLEAN
     mode: NULLABLE
-    description: null
   - name: name
     type: STRING
     mode: NULLABLE
-    description: null
   - name: user_disabled
     type: BOOLEAN
     mode: NULLABLE
-    description: null
   - name: app_disabled
     type: BOOLEAN
     mode: NULLABLE
-    description: null
   - name: version
     type: STRING
     mode: NULLABLE
-    description: null
   - name: scope
     type: INTEGER
     mode: NULLABLE
-    description: null
   - name: type
     type: STRING
     mode: NULLABLE
-    description: null
   - name: foreign_install
     type: BOOLEAN
     mode: NULLABLE
-    description: null
   - name: has_binary_components
     type: BOOLEAN
     mode: NULLABLE
-    description: null
   - name: install_day
     type: INTEGER
     mode: NULLABLE
-    description: null
   - name: update_day
     type: INTEGER
     mode: NULLABLE
-    description: null
   - name: signed_state
     type: INTEGER
     mode: NULLABLE
-    description: null
   - name: is_system
     type: BOOLEAN
     mode: NULLABLE
-    description: null
   - name: is_web_extension
     type: BOOLEAN
     mode: NULLABLE
-    description: null
   - name: multiprocess_compatible
     type: BOOLEAN
     mode: NULLABLE
-    description: null
-  description: null
 - name: active_hours_sum
   type: FLOAT
   mode: NULLABLE
-  description: null
 - name: addon_compatibility_check_enabled
   type: BOOLEAN
   mode: NULLABLE
-  description: null
 - name: app_build_id
   type: STRING
   mode: NULLABLE
-  description: null
 - name: app_display_version
   type: STRING
   mode: NULLABLE
-  description: null
 - name: app_name
   type: STRING
   mode: NULLABLE
-  description: null
 - name: app_version
   type: STRING
   mode: NULLABLE
-  description: null
 - name: attribution
   type: RECORD
   mode: NULLABLE
@@ -126,19 +97,15 @@
   - name: source
     type: STRING
     mode: NULLABLE
-    description: null
   - name: medium
     type: STRING
     mode: NULLABLE
-    description: null
   - name: campaign
     type: STRING
     mode: NULLABLE
-    description: null
   - name: content
     type: STRING
     mode: NULLABLE
-    description: null
   - name: experiment
     type: STRING
     mode: NULLABLE
@@ -154,163 +121,123 @@
   - name: ua
     type: STRING
     mode: NULLABLE
-  description: null
 - name: blocklist_enabled
   type: BOOLEAN
   mode: NULLABLE
-  description: null
 - name: channel
   type: STRING
   mode: NULLABLE
-  description: null
 - name: client_clock_skew_mean
   type: FLOAT
   mode: NULLABLE
-  description: null
 - name: client_submission_latency_mean
   type: FLOAT
   mode: NULLABLE
-  description: null
 - name: cpu_cores
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: cpu_count
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: cpu_family
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: cpu_l2_cache_kb
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: cpu_l3_cache_kb
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: cpu_model
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: cpu_speed_mhz
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: cpu_stepping
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: cpu_vendor
   type: STRING
   mode: NULLABLE
-  description: null
 - name: crashes_detected_content_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: crashes_detected_gmplugin_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: crashes_detected_plugin_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: crash_submit_attempt_content_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: crash_submit_attempt_main_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: crash_submit_attempt_plugin_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: crash_submit_success_content_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: crash_submit_success_main_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: crash_submit_success_plugin_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: default_search_engine
   type: STRING
   mode: NULLABLE
-  description: null
 - name: default_search_engine_data_load_path
   type: STRING
   mode: NULLABLE
-  description: null
 - name: default_search_engine_data_name
   type: STRING
   mode: NULLABLE
-  description: null
 - name: default_search_engine_data_origin
   type: STRING
   mode: NULLABLE
-  description: null
 - name: default_search_engine_data_submission_url
   type: STRING
   mode: NULLABLE
-  description: null
 - name: devtools_toolbox_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: distribution_id
   type: STRING
   mode: NULLABLE
-  description: null
 - name: e10s_enabled
   type: BOOLEAN
   mode: NULLABLE
-  description: null
 - name: env_build_arch
   type: STRING
   mode: NULLABLE
-  description: null
 - name: env_build_id
   type: STRING
   mode: NULLABLE
-  description: null
 - name: env_build_version
   type: STRING
   mode: NULLABLE
-  description: null
 - name: environment_settings_intl_accept_languages
   type: STRING
   mode: REPEATED
-  description: null
 - name: environment_settings_intl_app_locales
   type: STRING
   mode: REPEATED
-  description: null
 - name: environment_settings_intl_available_locales
   type: STRING
   mode: REPEATED
-  description: null
 - name: environment_settings_intl_requested_locales
   type: STRING
   mode: REPEATED
-  description: null
 - name: environment_settings_intl_system_locales
   type: STRING
   mode: REPEATED
-  description: null
 - name: environment_settings_intl_regional_prefs_locales
   type: STRING
   mode: REPEATED
-  description: null
 - name: experiments
   type: RECORD
   mode: REPEATED
@@ -318,352 +245,264 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: STRING
     mode: NULLABLE
-    description: null
-  description: null
 - name: first_paint_mean
   type: FLOAT
   mode: NULLABLE
-  description: null
 - name: flash_version
   type: STRING
   mode: NULLABLE
-  description: null
 - name: country
   type: STRING
   mode: NULLABLE
-  description: null
 - name: city
   type: STRING
   mode: NULLABLE
-  description: null
 - name: geo_subdivision1
   type: STRING
   mode: NULLABLE
-  description: null
 - name: geo_subdivision2
   type: STRING
   mode: NULLABLE
-  description: null
 - name: isp_name
   type: STRING
   mode: NULLABLE
-  description: null
 - name: isp_organization
   type: STRING
   mode: NULLABLE
-  description: null
 - name: gfx_features_advanced_layers_status
   type: STRING
   mode: NULLABLE
-  description: null
 - name: gfx_features_d2d_status
   type: STRING
   mode: NULLABLE
-  description: null
 - name: gfx_features_d3d11_status
   type: STRING
   mode: NULLABLE
-  description: null
 - name: gfx_features_gpu_process_status
   type: STRING
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_aboutdebugging_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_animationinspector_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_browserconsole_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_canvasdebugger_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_computedview_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_custom_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_dom_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_eyedropper_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_fontinspector_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_inspector_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_jsbrowserdebugger_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_jsdebugger_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_jsprofiler_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_layoutview_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_memory_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_menu_eyedropper_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_netmonitor_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_options_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_paintflashing_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_picker_eyedropper_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_responsive_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_ruleview_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_scratchpad_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_scratchpad_window_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_shadereditor_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_storage_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_styleeditor_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_webaudioeditor_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_webconsole_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: histogram_parent_devtools_webide_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: install_year
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: is_default_browser
   type: BOOLEAN
   mode: NULLABLE
-  description: null
 - name: is_wow64
   type: BOOLEAN
   mode: NULLABLE
-  description: null
 - name: locale
   type: STRING
   mode: NULLABLE
-  description: null
 - name: memory_mb
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: normalized_channel
   type: STRING
   mode: NULLABLE
-  description: null
 - name: normalized_os_version
   type: STRING
   mode: NULLABLE
-  description: null
 - name: os
   type: STRING
   mode: NULLABLE
-  description: null
 - name: os_service_pack_major
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: os_service_pack_minor
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: os_version
   type: STRING
   mode: NULLABLE
-  description: null
 - name: pings_aggregated_by_this_row
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: places_bookmarks_count_mean
   type: FLOAT
   mode: NULLABLE
-  description: null
 - name: places_pages_count_mean
   type: FLOAT
   mode: NULLABLE
-  description: null
 - name: plugin_hangs_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: plugins_infobar_allow_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: plugins_infobar_block_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: plugins_infobar_shown_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: plugins_notification_shown_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: previous_build_id
   type: STRING
   mode: NULLABLE
-  description: null
 - name: profile_age_in_days
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: profile_creation_date
   type: STRING
   mode: NULLABLE
-  description: null
 - name: push_api_notify_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: sample_id
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: sandbox_effective_content_process_level
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_combined_webrtc_nicer_stun_retransmits_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_combined_webrtc_nicer_turn_401s_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_combined_webrtc_nicer_turn_403s_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_combined_webrtc_nicer_turn_438s_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_content_navigator_storage_estimate_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_content_navigator_storage_persist_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_aushelper_websense_reg_version
   type: STRING
   mode: NULLABLE
-  description: null
 - name: scalar_parent_browser_engagement_max_concurrent_tab_count_max
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_browser_engagement_max_concurrent_window_count_max
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_browser_engagement_tab_open_event_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_browser_engagement_total_uri_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_browser_engagement_unfiltered_uri_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_browser_engagement_unique_domains_count_max
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_browser_engagement_unique_domains_count_mean
   type: FLOAT
   mode: NULLABLE
-  description: null
 - name: scalar_parent_browser_engagement_window_open_event_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_devtools_accessibility_node_inspected_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_devtools_accessibility_opened_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_devtools_accessibility_picker_used_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_devtools_accessibility_select_accessible_for_node_sum
   type: RECORD
   mode: REPEATED
@@ -671,211 +510,159 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_devtools_accessibility_service_enabled_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_devtools_copy_full_css_selector_opened_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_devtools_copy_unique_css_selector_opened_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_devtools_toolbar_eyedropper_opened_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_navigator_storage_estimate_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_navigator_storage_persist_count_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_storage_sync_api_usage_extensions_using_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_cohort
   type: STRING
   mode: NULLABLE
-  description: null
 - name: search_count_abouthome
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_count_contextmenu
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_count_newtab
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_count_searchbar
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_count_system
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_count_urlbar
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_count_all
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_count_tagged_sap
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_count_tagged_follow_on
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_count_organic
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_count_urlbar_handoff
   type: INTEGER
   mode: NULLABLE
 - name: session_restored_mean
   type: FLOAT
   mode: NULLABLE
-  description: null
 - name: sessions_started_on_this_day
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: shutdown_kill_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: subsession_hours_sum
   type: NUMERIC
   mode: NULLABLE
-  description: null
 - name: ssl_handshake_result_failure_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: ssl_handshake_result_success_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: sync_configured
   type: BOOLEAN
   mode: NULLABLE
-  description: null
 - name: sync_count_desktop_mean
   type: FLOAT
   mode: NULLABLE
-  description: null
 - name: sync_count_mobile_mean
   type: FLOAT
   mode: NULLABLE
-  description: null
 - name: sync_count_desktop_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: sync_count_mobile_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: telemetry_enabled
   type: BOOLEAN
   mode: NULLABLE
-  description: null
 - name: timezone_offset
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: update_auto_download
   type: BOOLEAN
   mode: NULLABLE
-  description: null
 - name: update_channel
   type: STRING
   mode: NULLABLE
-  description: null
 - name: update_enabled
   type: BOOLEAN
   mode: NULLABLE
-  description: null
 - name: vendor
   type: STRING
   mode: NULLABLE
-  description: null
 - name: web_notification_shown_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: windows_build_number
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: windows_ubr
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: fxa_configured
   type: BOOLEAN
   mode: NULLABLE
-  description: null
 - name: trackers_blocked_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: submission_timestamp_min
   type: TIMESTAMP
   mode: NULLABLE
-  description: null
 - name: ad_clicks_count_all
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: search_with_ads_count_all
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_urlbar_impression_autofill_about_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_urlbar_impression_autofill_adaptive_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_urlbar_impression_autofill_origin_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_urlbar_impression_autofill_other_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_urlbar_impression_autofill_preloaded_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_urlbar_impression_autofill_url_sum
   type: INTEGER
   mode: NULLABLE
-  description: null
 - name: scalar_parent_telemetry_event_counts_sum
   type: RECORD
   mode: REPEATED
@@ -883,12 +670,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_content_telemetry_event_counts_sum
   type: RECORD
   mode: REPEATED
@@ -896,12 +680,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_bookmarkmenu_sum
   type: RECORD
   mode: REPEATED
@@ -909,12 +690,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_handoff_sum
   type: RECORD
   mode: REPEATED
@@ -922,12 +700,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_keywordoffer_sum
   type: RECORD
   mode: REPEATED
@@ -935,12 +710,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_oneoff_sum
   type: RECORD
   mode: REPEATED
@@ -948,12 +720,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_other_sum
   type: RECORD
   mode: REPEATED
@@ -961,12 +730,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_shortcut_sum
   type: RECORD
   mode: REPEATED
@@ -974,12 +740,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_tabmenu_sum
   type: RECORD
   mode: REPEATED
@@ -987,12 +750,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_tabtosearch_sum
   type: RECORD
   mode: REPEATED
@@ -1000,12 +760,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_tabtosearch_onboard_sum
   type: RECORD
   mode: REPEATED
@@ -1013,12 +770,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_topsites_newtab_sum
   type: RECORD
   mode: REPEATED
@@ -1026,12 +780,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_topsites_urlbar_sum
   type: RECORD
   mode: REPEATED
@@ -1039,12 +790,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_touchbar_sum
   type: RECORD
   mode: REPEATED
@@ -1052,12 +800,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_urlbar_searchmode_typed_sum
   type: RECORD
   mode: REPEATED
@@ -1065,12 +810,9 @@
   - name: key
     type: STRING
     mode: NULLABLE
-    description: null
   - name: value
     type: INTEGER
     mode: NULLABLE
-    description: null
-  description: null
 - name: scalar_parent_os_environment_is_taskbar_pinned
   type: BOOLEAN
   mode: NULLABLE
@@ -2028,8 +1770,6 @@
 - name: profile_group_id
   type: STRING
   mode: NULLABLE
-  description: A UUID identifying the profile's group on a single device and allowing
-    user-oriented correlation of data
 - name: browser_version_info
   type: RECORD
   mode: NULLABLE
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_last_seen/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_last_seen/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_last_seen/schema.yaml	2024-11-20 02:20:59.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/clients_last_seen/schema.yaml	2024-11-20 02:29:38.000000000 +0000
@@ -77,44 +77,33 @@
 - name: submission_date
   type: DATE
   mode: NULLABLE
-  description: Submission Date
 - name: first_seen_date
   type: DATE
   mode: NULLABLE
-  description: First Seen Date
 - name: second_seen_date
   type: DATE
   mode: NULLABLE
-  description: Second Seen Date
 - name: days_seen_bits
   type: INTEGER
   mode: NULLABLE
-  description: Bit pattern to identify when the client_id has sent a main ping in
-    the previous 28 days.
 - name: days_visited_1_uri_bits
   type: INTEGER
   mode: NULLABLE
-  description: Days Visited 1 URI Bits
 - name: days_visited_5_uri_bits
   type: INTEGER
   mode: NULLABLE
-  description: Days Visited 5 URI Bits
 - name: days_visited_10_uri_bits
   type: INTEGER
   mode: NULLABLE
-  description: Days Visited 10 URI Bits
 - name: days_had_8_active_ticks_bits
   type: INTEGER
   mode: NULLABLE
-  description: Days Had 8 Active Ticks Bits
 - name: days_opened_dev_tools_bits
   type: INTEGER
   mode: NULLABLE
-  description: Days Opened Dev Tools Bits
 - name: days_interacted_bits
   type: INTEGER
   mode: NULLABLE
-  description: Days Interacted Bits
 - name: days_visited_1_uri_normal_mode_bits
   type: INTEGER
   mode: NULLABLE
@@ -143,23 +132,18 @@
 - name: client_id
   type: STRING
   mode: NULLABLE
-  description: Client ID
 - name: aborts_content_sum
   type: INTEGER
   mode: NULLABLE
-  description: Aborts Content Sum
 - name

⚠️ Only part of the diff is displayed.

Link to full diff

Copy link
Contributor

@lucia-vargas-a lucia-vargas-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the shredder_mitigation validations to pass, a schema file with descriptions would be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants