DENG-6360 complete backfill with shredder mitigation for desktop aua v4 #6539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o complete desktop backfill, update codeowners.
…tigation_for_desktop_aua_v4
This comment has been minimized.
This comment has been minimized.
lucia-vargas-a
changed the title
…tigation_for_desktop_aua_v4
…e_name in the metadata template.
Integration report for "Update desktop column names in view active_users_aggregates. Use table_name in the metadata template."
|
bochocki
reviewed
Nov 21, 2024
Comment on lines
+229
to
+256
| elif browser.name == "firefox_desktop": | ||
| write_sql( | ||
| output_dir=output_dir, | ||
| full_table_id=f"{target_project}.{browser.name}.{BASE_NAME}", | ||
| basename="view.sql", | ||
| sql=reformat( | ||
| view_template.render( | ||
| project_id=target_project, | ||
| app_name=browser.name, | ||
| table_name=TABLE_NAME, | ||
| ) | ||
| ), | ||
| skip_existing=False, | ||
| ) | ||
| else: | ||
| write_sql( | ||
| output_dir=output_dir, | ||
| full_table_id=f"{target_project}.{browser.name}.{BASE_NAME}", | ||
| basename="view.sql", | ||
| sql=reformat( | ||
| view_template.render( | ||
| project_id=target_project, | ||
| app_name=browser.name, | ||
| table_name=TABLE_NAME, | ||
| ) | ||
| ), | ||
| skip_existing=False, | ||
| ) |
There was a problem hiding this comment.
These two conditions seem to be identical... is that intentional? If so, could you remove the elif and just use the else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the backfill for
firefox_desktop_derived.active_users_aggregates_v4and updates the views to use the new version. Details in the related ticket.Reviewer, please note that approving this PR indicates that KPI data is validated and correct to move to production.
Related Tickets & Documents
DENG-6360
Reviewer, please follow this checklist
┆Issue is synchronized with this Jira Task