Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable two rules for two WebCompat components #2548

Closed
denschub opened this issue Nov 27, 2024 · 3 comments · Fixed by #2549
Closed

Disable two rules for two WebCompat components #2548

denschub opened this issue Nov 27, 2024 · 3 comments · Fixed by #2549

Comments

@denschub
Copy link
Member

Follow-up to #2533, we want to disable

  • no_severity_ni
  • no_severity_nag

for bugs inside

  • Web Compatibility::Knowledge Base
  • Web Compatibility::Tooling & Investigations

The bugs in these components aren't real-world site bugs, they're collection of task lists or metebugs. The severity are driven by the blocking bugs' P and S - so we don't really want to be nagged.

@denschub
Copy link
Member Author

@marco-c I'd submit a PR, but I'm not entirely sure how. Looking at the workflow impl, it seems like those workflows read workflow.components_skiplist. But looking at configs/rules.json, it seems like this is a global config. How can I disable these specific BugBot workflows for those two components only?

@suhaibmujahid
Copy link
Member

If you add a component to workflow.components_skiplist, it will disable the following rules:

  • no_severity_nag
  • no_severity_ni
  • p1_no_assignee

Since you are interested in disabling the rules for no_severity_nag and no_severity_ni only, you could add a local skiplist in configs/rules.json and merge it with the workflow skiplist for each of the rules that you are targeting.

For example, for the no_severity_nag rule, you could do that after the following line:

self.components_skiplist = utils.get_config("workflow", "components_skiplist")

You could read the local skiplist with:

self.get_config("components_skiplist")

@denschub
Copy link
Member Author

I'm also fine with disabling p1_no_assignee, to be honest. Most of those issues are not assigned - and we just didn't notice that nag yet because no issues are P1.

I'll submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants