-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for the crawler #32
Comments
Yes, I would like to work on it. Shall we create a |
Yes! Let's start by changing the project structure to put a test folder with an empty test and a directory "coverage_crawler" where we put the code. |
Hi @marco-c
|
That sounds good, I would file a separate issue for changing the project structure. |
@marco-c This repo looks pretty inactive, but if you're still here, could you please suggest some tests we could implement? |
@nnrepos it is inactive at the moment, but the plan is to work on this when time will allow. |
hey @marco-c, i created a unittest to see if i understand what you need. please let me know what you think 😄 |
thanks for the support @marco-c :) |
@nnrepos we should add a unit test for each function in the crawler (when it is possible, of course). Feel free to open a PR for each test/function. |
@marco-c alright. |
@nnrepos ideally we should run a local server so we can fully control the contents. |
So far, we have no tests.
The text was updated successfully, but these errors were encountered: