Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for the crawler #32

Open
marco-c opened this issue Mar 20, 2018 · 11 comments
Open

Add unit tests for the crawler #32

marco-c opened this issue Mar 20, 2018 · 11 comments

Comments

@marco-c
Copy link
Collaborator

marco-c commented Mar 20, 2018

So far, we have no tests.

@Sush0512
Copy link
Contributor

Yes, I would like to work on it. Shall we create a test folder and add all the unit tests?

@marco-c
Copy link
Collaborator Author

marco-c commented Mar 20, 2018

Yes! Let's start by changing the project structure to put a test folder with an empty test and a directory "coverage_crawler" where we put the code.
We can use pytest for testing.

@Sush0512
Copy link
Contributor

Hi @marco-c
Dividing the issue into subtasks, if anything else needs to be added please let me know.

  • Change the project structure
  • Add unit tests in test folder

@marco-c
Copy link
Collaborator Author

marco-c commented Mar 22, 2018

That sounds good, I would file a separate issue for changing the project structure.

@nnrepos
Copy link
Contributor

nnrepos commented Nov 4, 2019

@marco-c This repo looks pretty inactive, but if you're still here, could you please suggest some tests we could implement?

@marco-c
Copy link
Collaborator Author

marco-c commented Nov 6, 2019

@nnrepos it is inactive at the moment, but the plan is to work on this when time will allow.
Regarding tests, we have basically 0 coverage for the crawler, so you could start by adding tests for the simplest functions in crawler.py.

@nnrepos
Copy link
Contributor

nnrepos commented Oct 14, 2022

hey @marco-c, i created a unittest to see if i understand what you need. please let me know what you think 😄

@nnrepos
Copy link
Contributor

nnrepos commented Oct 17, 2022

thanks for the support @marco-c :)
i would like to know - what should the next steps be? would you like me to add a unittest for every crawler method? perhaps some integration tests? something specific you would like to be tested?
a task list would be appreciated

@marco-c
Copy link
Collaborator Author

marco-c commented Oct 17, 2022

@nnrepos we should add a unit test for each function in the crawler (when it is possible, of course). Feel free to open a PR for each test/function.

@nnrepos
Copy link
Contributor

nnrepos commented Oct 20, 2022

@marco-c alright.
since we don't want to create calls to google.com, is there any other website i am allowed to test on? something that is expected to rarely (hopefully never) change, and is reliable? perhaps the page of this repository in github?

@marco-c
Copy link
Collaborator Author

marco-c commented Oct 20, 2022

@nnrepos ideally we should run a local server so we can fully control the contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants