We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When logging qlog events, we currently use qlog's add_event_data_now which internally calls std::time::Instant::now().
qlog
add_event_data_now
std::time::Instant::now()
neqo/neqo-common/src/qlog.rs
Line 117 in e08c14f
This is fine when capturing qlogs in real-time.
Problem arises when used with the text_fixtures::Simulator, which simulates time, i.e. where std::time::Instant::now() has no meaning.
text_fixtures::Simulator
I suggest we use qlogs add_event_data_with_instant, using now: Instant available e.g. through now parameter on Connection::process.
add_event_data_with_instant
now: Instant
now
Connection::process
neqo/neqo-transport/src/connection/mod.rs
Line 1165 in e08c14f
Status: preparing a draft. Thus far, this is very noisy, given that now needs to be passed across many layers.
The text was updated successfully, but these errors were encountered:
Sound good.
Related, it would be nice to see virtual time in the debug output for tests, and not clock time.
Sorry, something went wrong.
I sketched a fix for this issue in #2212. Long story short, I don't think it is worth it. See PR description in #2212.
Let me know if you think otherwise, or have a better solution.
Successfully merging a pull request may close this issue.
When logging qlog events, we currently use
qlog
'sadd_event_data_now
which internally callsstd::time::Instant::now()
.neqo/neqo-common/src/qlog.rs
Line 117 in e08c14f
This is fine when capturing qlogs in real-time.
Problem arises when used with the
text_fixtures::Simulator
, which simulates time, i.e. wherestd::time::Instant::now()
has no meaning.I suggest we use
qlog
sadd_event_data_with_instant
, usingnow: Instant
available e.g. throughnow
parameter onConnection::process
.neqo/neqo-transport/src/connection/mod.rs
Line 1165 in e08c14f
Status: preparing a draft. Thus far, this is very noisy, given that
now
needs to be passed across many layers.The text was updated successfully, but these errors were encountered: