Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the integration test in a random order #19065

Open
timvandermeij opened this issue Nov 17, 2024 · 1 comment
Open

Run the integration test in a random order #19065

timvandermeij opened this issue Nov 17, 2024 · 1 comment
Labels

Comments

@timvandermeij
Copy link
Contributor

The integration tests currently run in a fixed order, see https://github.com/mozilla/pdf.js/blob/master/test/integration-boot.mjs#L24, which is in contrast with e.g. the unit test that deliberately run in a random order to bring any isolation issues (dependencies between tests) to the surface. Most likely this wasn't done for the integration tests yet because we used to have quite a lot of intermittent issues and dependencies between tests when we started with the integration tests, but over time we have fixed most of them so hopefully running the integration tests in a random order is more feasible nowadays.

We should try this out and make a list of any issues we encounter. This could involve closing the document between tests in the same describe block to avoid state leaking through to subsequent tests; see e.g. PR #19064 for which an alternative solution was implemented.

@calixteman
Copy link
Contributor

See #19064 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants