Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Shift the signature editor when pasted #19539

Merged
merged 1 commit into from
Feb 24, 2025
Merged

[Editor] Shift the signature editor when pasted #19539

merged 1 commit into from
Feb 24, 2025

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8425d8e22dae8a7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/97f42cd09b057a2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/8425d8e22dae8a7/output.txt

Total script time: 15.38 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/97f42cd09b057a2/output.txt

Total script time: 30.96 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0400cbfff214532/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0fff0fc0818bcf7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/0400cbfff214532/output.txt

Total script time: 12.30 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/0fff0fc0818bcf7/output.txt

Total script time: 29.00 mins

  • Integration Tests: FAILED

@calixteman calixteman requested review from Snuffleupagus and removed request for Snuffleupagus February 22, 2025 20:18
@Snuffleupagus
Copy link
Collaborator

Any more details about what's changing and why would be most helpful here (the commit message is a bit short), since I'm not entirely sure what problem(s) this patch is fixing?

@calixteman
[Editor] Shift the signature editor when pasted
cc3d6ab 
The idea is to avoid to have the pasted editor hidding the copied one:
the user could think that nothing happened.
So the top-left corner of the pasted one is moved to the bottom-right corner of the copied one.
@Snuffleupagus
Copy link
Collaborator

Thanks for the additional context, that helps!

A question, based on quickly testing this locally:
It seems that this only works for the first paste, since pasting an editor multiple times still overlays them; is that intended?

@calixteman
Copy link
Contributor Author

Yep you're right.
I'd like to make a release today, wdyt about merging this PR and I'll do a follow-up in the week ?

Snuffleupagus
Snuffleupagus approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@calixteman calixteman merged commit f9aa8e1 into mozilla:master Feb 24, 2025
9 checks passed
@calixteman calixteman deleted the paste_signature branch February 24, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus