Fix the link for issue5939.pdf #19545
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web archive no longer has the revision for the saved PDF referenced in that test case, so this updates that link to a more recent revision to enable the tests to run on a clean clone.
Snuffleupagus
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Note that this can't be (easily) tested on the bots, since they already have the file cached.
Hence I've done the following locally, with this patch applied:
- Temporarily moved the
issue5939.pdffile to another folder, to trigger re-downloading. - Ran
gulp browsertest --noChrome -t issue5939, to trigger downloading of the file and run reference tests. - Ensured that the test passed and there were no warnings/errors about hash mismatches, confirming that the "new" file is identical to the previous one.
r=me, thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web archive no longer has the revision for the saved PDF referenced in that test case, so this updates that link to a more recent revision to enable the tests to run on a clean clone.