-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-minor] Stop exporting, by default, a few additional Font properties (PR 11777 follow-up) #19549
[api-minor] Stop exporting, by default, a few additional Font properties (PR 11777 follow-up) #19549
Conversation
…ies (PR 11777 follow-up) None of the "composite", "subtype", or "type" properties are normally used on the main-thread and/or in the API, hence there's no need to include them in the exported font-data by default. Given that these properties may still be useful when debugging, and that `debugger.mjs` actually relies on the "type" property, they will instead only be sent to the main-thread when the `fontExtraProperties` API-option is used.
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4597cfadd004435/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ae47b22967d1aca/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4597cfadd004435/output.txt Total script time: 2.49 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/ae47b22967d1aca/output.txt Total script time: 7.57 mins
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b34f2cd782cbc87/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/58a31e6f523b594/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/58a31e6f523b594/output.txt Total script time: 17.25 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/b34f2cd782cbc87/output.txt Total script time: 30.29 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
None of the "composite", "subtype", or "type" properties are normally used on the main-thread and/or in the API, hence there's no need to include them in the exported font-data by default.
Given that these properties may still be useful when debugging, and that
debugger.mjs
actually relies on the "type" property, they will instead only be sent to the main-thread when thefontExtraProperties
API-option is used.