Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Create include.js tests #4146

Open
jaredhirsch opened this issue Jun 10, 2014 · 2 comments
Open

Create include.js tests #4146

jaredhirsch opened this issue Jun 10, 2014 · 2 comments

Comments

@jaredhirsch
Copy link
Member

BrowserSupport - use useragent npm package to generate a list of UA strings, verify that our sniffer does what it should.

Also mock out WinChan and test that the public and internal APIs behave properly. Just get some kind of protection in place :-)

@jaredhirsch
Copy link
Member Author

We can also start to rethink whether we need/want to be sniffing user-agent strings, it's just so gross

@shane-tomlinson
Copy link

This was touched upon in #483 and #1199, I am very surprised there is not already an open issue about this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants