Skip to content
This repository has been archived by the owner on Jun 29, 2018. It is now read-only.

Impossible to add YouTube/Vimeo controls via .controls() method? #451

Open
djvs opened this issue Jun 22, 2015 · 0 comments
Open

Impossible to add YouTube/Vimeo controls via .controls() method? #451

djvs opened this issue Jun 22, 2015 · 0 comments

Comments

@djvs
Copy link

djvs commented Jun 22, 2015

This patch was manually added into current stable popcorn-complete.js (to mimic future popcorn-complete releases):

https://github.com/mozilla/popcorn-js/pull/441/files?diff=split

such that Vimeo and YouTube methods all work (Popcorn.youtube, Popcorn.HTMLYoutubeVideoElement, etc.). Player starts and stops correctly on click. However, all video controls are missing, and calling popcorn.controls(true) has no effect, for:

            // "vidid", "vidurl", "elemid" all valid
            var vidurl = "http://player.vimeo.com/video/" + vidid;
            var player = new Popcorn.HTMLVimeoVideoElement("#"+elemid);
            player.src = vidurl;
            player = new Popcorn(player);
            player.controls(true);

Going into inspector and manually adding "controls" attribute to the video element inside the iframe does, however, enable the controls. Shouldn't adding it be a fallback for these wrappers or something similar? My only alternative is DOM manipulation inside the iframe...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant