Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit use of vendor prefix mixins #957

Open
janbrasna opened this issue Jul 25, 2024 · 1 comment
Open

Audit use of vendor prefix mixins #957

janbrasna opened this issue Jul 25, 2024 · 1 comment

Comments

@janbrasna
Copy link
Contributor

There are a handful of utility mixins sometimes serving "interesting" prefixed rules:

@mixin align-items($align: stretch) {
-webkit-box-align: $align;
align-items: $align;
}
@mixin justify-content($justify: flex-start) {
-webkit-box-pack: $justify;
justify-content: $justify;
}
@mixin background-size($sizes...) {
-webkit-background-size: $sizes;
background-size: $sizes;
}

(e.g. align-items is unprefixed since Safari 9, and Safari 8 had it prefixed, but the fallback to *-box-align i.e. another experimental property sounds rather complex for today's use; -webkit-background-size had a different logic applied to param count and didn't understand a handful of values etc.)

While definitely intriguing piece of code that must have been really helpful in the past decade, some bits are probably no longer relevant or necessary, and if used, only inflating the compiled output with no positive impact. Maybe it's time to audit if/where these are being used, and plan a decommission path to have them removed one day.

If a major/breaking release is coming up, that might help justifying some of the mixin removal, if they no longer serve the purpose and would just need to be kept around passing through the stable property for backwards compatibility of the API.

@amiii123malviya
Copy link

Hello ,

I hope you are doing well,

Is this issue still active I would like work on this issue.
Thankyou for your time , Looking forward for your response

Best Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants