Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

[shipit] There is no suggested revision, nor error message when the last commits of a repository are all DONTBUILD #2235

Open
JohanLorenzo opened this issue Aug 5, 2019 · 1 comment

Comments

@JohanLorenzo
Copy link
Contributor

It happened today with ESR68. @pascalchevrel and I were really confused. Nothing came up:

image

After some investigation, these lines are filtering all commits out:

const suggestedRevisions = Object.values(pushes.pushes).map(push =>
({ ...push.changesets[0], date: new Date(push.date * 1000) })).reverse().filter(push =>
push.desc.indexOf('DONTBUILD') === -1);

image

I think we should show a warning explaining why nothing comes up.

What do you think @rail ?

@rail
Copy link
Contributor

rail commented Aug 6, 2019

We definitely should warn when the list of suggestions is empty. Or maybe we can fetch more pushes in this case. Another option would be listing the DONTBUILD pushes, but make them not selectable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants