-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE - Update Bootstrap and add auto support for dark mode #821
base: main
Are you sure you want to change the base?
Conversation
FYI, you would just flip this to draft instead of the "DO NOT MERGE" |
Setting dark mode with JS at the end of |
Agreed on both points. I think we could get 90% of the way there without JS by copying a CSS rule from https://cdnjs.cloudflare.com/ajax/libs/bootstrap/5.3.0/css/bootstrap.css into a
although looking through that file there are other rules using the |
I've pushed a change to do the above comment. The main issue I see is that the glyphicons are missing in the latest version. Could migrate to these SVG icons if we do want to move forward here https://github.com/tabler/tabler-icons |
Nice. Switching to SVG icons SGTM |
This looks like a good direction. Finding SVG for icons seems like a good plan. ▶►▼▷▸ or other unicode symbols might work in some ways. |
#816 is probably easier, but this is an example that just bumps the version in npm to the latest boostrap, and includes their docs color-modes.js file as per https://github.com/orgs/twbs/discussions/37727 to allow the root element to get
[data-bs-theme="auto"]
for auto theme detection.Issues: