New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Update iOS CAPPluginCall access to use non-deprecated APIs #20

Open

lincolnthree opened this issue Mar 10, 2021 · 0 comments

lincolnthree commented Mar 10, 2021 •

edited

Loading

Description

Per Capacitor team, the NSString, BOOL, and NSNumber accessors for CAPPluginCall will be deprecated going forward, in favor of this api:

https://github.com/ionic-team/capacitor/blob/main/ios/Capacitor/Capacitor/JSTypes.swift
https://github.com/ionic-team/capacitor/blob/main/ios/Capacitor/Capacitor/CAPBridgedJSTypes.h (requires additional import statement)

See: ionic-team/capacitor#4303 (comment)

Resolution steps

The iOS implementation should be refactored to use these new methods:

https://github.com/mapiacompany/capacitor-codepush/blob/capacitor/ios/Plugin/CodePush.m#L177
https://github.com/mapiacompany/capacitor-codepush/blob/capacitor/ios/Plugin/CodePush.m#L190

And other places that reference the deprecated methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment