Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Vitess #19

Open
mpchadwick opened this issue Dec 12, 2024 · 0 comments
Open

Upgrade Vitess #19

mpchadwick opened this issue Dec 12, 2024 · 0 comments

Comments

@mpchadwick
Copy link
Owner

Notes to self:

It looks like we can't do sqlparser.Parse() anymore as of v0.19.0 which we do in processor.go

https://github.com/vitessio/vitess/blob/v0.18.0/go/vt/sqlparser/parser.go#L179
https://github.com/vitessio/vitess/blob/v0.19.0/go/vt/sqlparser/parser.go#L152

There may be some other breaking changes, that's what I've found so far.

Also, create_table.go is using github.com/blastrain/vitess-sqlparser/sqlparser instead of vitess.io/vitess/go/vt/sqlparser. I can't remember why they are using different parsers, but it would be good to try to be consistent if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant