Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmap slicer improvements #143

Open
ianhi opened this issue Nov 21, 2020 · 0 comments
Open

Heatmap slicer improvements #143

ianhi opened this issue Nov 21, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ianhi
Copy link
Collaborator

ianhi commented Nov 21, 2020

Meta issue to keep track of the various potential improvements to hyperslicer raised in:
#57
#33
#29

as those issues have significant overlap.

29: allow arbitrary angles of heatmap slicer
e.g. heatmap_slicer(arr1, arr2, slices = [15, 37]) for slices at 15 and 37 degrees.

33: truly arbitrary slices of heatmaps
with a draggable line on the image following some of the examples in: https://stackoverflow.com/questions/7878398/how-to-extract-an-arbitrary-line-of-values-from-a-numpy-array

(I'm less stoked about this one currently - seems hard to do well and not like a huge value add)

57:

Currently slices accepts: 'vertical', 'horizontal', and 'both'. This has potential to become a nightmare of special casing once arbitrary angles are supported. In particular it should probably not accept 'both' and instead you use a list to specify.

or at the very least both should be renamed to something more descriptive like cross hairs or something that will still have semantic meaning when arbitrary angles are supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant