Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APNS] Migrate to apns2 or aioapns #580

Open
amotl opened this issue Aug 22, 2022 · 3 comments
Open

[APNS] Migrate to apns2 or aioapns #580

amotl opened this issue Aug 22, 2022 · 3 comments
Labels
help wanted service plugin All about service plugins

Comments

@amotl
Copy link
Member

amotl commented Aug 22, 2022

Hi there,

@LaborEtArs asked at #396 (comment):

Are there plans to update the apns plugin to apns2?

apns did not receive any updates since 2015, apns2 does a better job here, the most recent release is from 2020. So, indeed, the plugin should be updated accordingly.

With kind regards,
Andreas.

@amotl amotl added bug service plugin All about service plugins labels Aug 22, 2022
@amotl
Copy link
Member Author

amotl commented Aug 22, 2022

On the issue tracker of the PyAPNs2 repository, I found those:

Because of that, it looks like some other projects switched to the aioapns library in the meanwhile. We should probably do the same.

@amotl amotl changed the title [APNS] Migrate from apns to apns2 [APNS] Migrate to aioapns Aug 22, 2022
@amotl
Copy link
Member Author

amotl commented Aug 26, 2022

Dear @LaborEtArs,

if this can spark your interest, we will be very happy to receive corresponding patches in order to be able to support the Apple Push Notification service again. Based on my research, I think using the aioapns library would be the right choice today.

With kind regards,
Andreas.

@amotl
Copy link
Member Author

amotl commented Nov 20, 2022

I've also just evaluated apns2, but it will not work on Python3.11 until the issues referenced at #580 (comment) got resolved. There is progress on this now at Pr0Ger/PyAPNs2#149, thanks to @salty-horse.

@amotl amotl changed the title [APNS] Migrate to aioapns [APNS] Migrate to apns2 or aioapns Nov 20, 2022
@amotl amotl added help wanted and removed bug labels May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted service plugin All about service plugins
Projects
None yet
Development

No branches or pull requests

1 participant