Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server's topicAliasMaximum is not relevant to client's topicAliasMaximum #1183

Closed
heunghingwan opened this issue Oct 19, 2020 · 2 comments
Closed

server's topicAliasMaximum is not relevant to client's topicAliasMaximum #1183

heunghingwan opened this issue Oct 19, 2020 · 2 comments

Comments

@heunghingwan
Copy link

heunghingwan commented Oct 19, 2020 •
edited by elhorton
Loading

hi,
I think this is a bug, topicAliasMaximum in CONNACK is for client to send to server, it should not overwrite CONNECT options, this will be a problem when reconnect.

MQTT.js/lib/client.js

Line 1174 in 70a247c

options.properties.topicAliasMaximum = packet.properties.topicAliasMaximum

AB#8607503
@YoDaMa
Copy link
Contributor

YoDaMa commented Oct 26, 2020

please create a PR addressing it if it is a bug.

@heunghingwan heunghingwan mentioned this issue Nov 3, 2020
Closed
@heunghingwan
Copy link
Author

fix by #1301 (#1300 for detail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YoDaMa @heunghingwan