Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox SVG rendering #58

Open
mrbeam opened this issue Dec 8, 2015 · 2 comments
Open

Firefox SVG rendering #58

mrbeam opened this issue Dec 8, 2015 · 2 comments
Labels

Comments

@mrbeam
Copy link
Collaborator

mrbeam commented Dec 8, 2015

is crashing because of 'probably' this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=700533

'''
source.onload = function () {
renderCanvasContext.drawImage(source, 0, 0, renderCanvas.width, renderCanvas.height);

        // place fill bitmap into svg
        var fillBitmap = renderCanvas.toDataURL("image/png");
        if(typeof callback === 'function'){
            callback(fillBitmap);
        }
        renderCanvas.remove();
    };

    // catch browsers without native svg support
    source.onerror = function() {
        console.error("Can't export! Maybe your browser doesn't support native SVG. Sorry.");
    };
};

'''
is running into the onerror case.

TODO: check if svg width and height is properly set and read the bug report for possible workarounds.

@mrbeam mrbeam added the bug label Dec 8, 2015
@make-ing
Copy link

make-ing commented Jun 2, 2016

Can't reproduce this bug. Need more information.

@make-ing make-ing self-assigned this Jun 16, 2016
@make-ing
Copy link

ok i can reproduce it now... It only happens for bitmaps like jpg and png.

@make-ing make-ing removed their assignment Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant