Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow style, option to highlight more than one character #1

Closed
floscher opened this issue Jun 7, 2024 · 7 comments
Closed

Arrow style, option to highlight more than one character #1

floscher opened this issue Jun 7, 2024 · 7 comments

Comments

@floscher
Copy link

floscher commented Jun 7, 2024

A small idea for the arrows, I think in the other direction they could look a bit nicer:

 ↑       │
 │   vs  │
 └─      └─►

Also, then the other end of the arrow could be used to highlight more than just one character like this (either automatically extending to the nearest whitespaces, or passing it a start and end index):

The quick brown fox jumps over the lazy dog
    ━┯━━━ ━┯━━━                    ━┯━━
     │     └─► adjective            └─► adjective
     │
     └─► adjective
@ccoVeille
Copy link

Maybe, you can have a look at what is done with https://github.com/rhysd/actionlint (hi @rhysd 👋)

@mrclmr
Copy link
Owner

mrclmr commented Jun 19, 2024

Hey, thanks for your ideas and inputs. I plan to implement ranged annotations to allow usage for example in https://github.com/rhysd/actionlint.

@mrclmr
Copy link
Owner

mrclmr commented Jun 26, 2024

@floscher @ccoVeille If #5 solves the ranged annotations and #4 addresses the custom arrow style, can this issue be closed? :)

@ccoVeille
Copy link

Sure, it's great. Please let me know about your progression in https://github.com/rhysd/actionlint or any project you consider using your tool.

@ccoVeille
Copy link

I cannot close, so please do

@mrclmr mrclmr closed this as completed Jun 26, 2024
@mrclmr
Copy link
Owner

mrclmr commented Jun 26, 2024

I think it is better if @floscher closes the issue if it is closable :)

@mrclmr mrclmr reopened this Jun 26, 2024
@floscher
Copy link
Author

@meyermarcel Sure, this can be closed. Feel free to do as much or little about this issue as you want 😉. At the moment I don't have a real usecase for your project myself, so it was more a suggestion than a real issue/problem I had with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants