Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super FX screen flicker #262

Open
Sunlitspace542 opened this issue Sep 13, 2024 · 18 comments
Open

Super FX screen flicker #262

Sunlitspace542 opened this issue Sep 13, 2024 · 18 comments

Comments

@Sunlitspace542
Copy link

I am using an SD2SNES Mk. II Rev. J, running this firmware: https://github.com/mrehkopf/sd2snes/files/10765998/issue186.zip
In some Super FX romhacks, the screen can flash solid black for a frame. Booting the ROM over USB with QUSB2SNES fixes this issue.
Apologies for the blurry video, but it should be enough to demonstrate the issue.

superfxflicker_8mb.mp4
@mrehkopf
Copy link
Owner

Can you check if you have the brightness limit or 1chip transient fix enabled in configuration->in-game settings? They don't work reliably with every game due to differences in how each game programs the blanking/brightness register.
It probably works using qusb2snes because it doesn't set all features when loading a ROM.

@Sunlitspace542
Copy link
Author

Can you check if you have the brightness limit or 1chip transient fix enabled in configuration->in-game settings?

Just checked, and I don't.

@r0g1nh0
Copy link

r0g1nh0 commented Sep 13, 2024

With firmware issue186, very thin vertical lines also appear in the Super Mario RPG game and the graphics are of lower quality in others.

@Ramsis-SNES
Copy link

In some Super FX romhacks

Which one(s) specifically? Star Fox Exploration, perhaps?

Please bear in mind that in most cases, before finding the cause of an issue you might experience, let alone making any attempt to fix it, a developer has to reproduce it first, i.e. provoke it and see it happen on their own setup. This is obviously only possible and/or becomes a lot easier if you provide as much information with as many details as you can in your report. That said, the name of the game/hack you're having trouble with should be the absolute bare minimum of information to include in it. :-)

@Sunlitspace542
Copy link
Author

The footage is of Star Fox Next Gen, I am on the development team. This one has the worst case of it, though it does happen a bit on the title screen of Star Fox EX.

@mrehkopf
Copy link
Owner

Oh, totally missed that fact ^^; The in-game hook is also a possible cause for problems. I am not aware of any issues with Star Fox, however that may or may not be true for ROM hacks depending on the modifications made...

@Sunlitspace542
Copy link
Author

I don't have in-game hooks enabled either. I also haven't been able to reproduce it on any particularly accurate emulators.

@Sunlitspace542
Copy link
Author

Sunlitspace542 commented Sep 13, 2024

I just tried enabling in-game hooks and the flickering is gone, at least in the part of the game I showed in the video. Booting over USB fixes all flickering issues.
I enabled in-game hooks, and the associated options "in-game buttons" and "initial holdoff" are disabled. All other in-game settings are disabled.
This doesn't appear to fix the title screen flicker in Star Fox EX I mentioned previously, but it does for this particular hack.

@mrehkopf
Copy link
Owner

Is there a patch available publicly? I'd like to check it out. (Though I'll be gone over the weekend)
I assume that it doesn't happen on a vanilla ROM? (It doesn't for me)

@Sunlitspace542
Copy link
Author

It's still in very early development at the moment.
I haven't had it happen with vanilla Star Fox or Star Fox 2.

@Sunlitspace542
Copy link
Author

Anyway though, as I said enabling in-game hooks is only a partial fix, as it only fixes flicker in the part I showed in the video.
Booting over USB eliminates all flicker.

@mrehkopf
Copy link
Owner

Right now I am leaning towards the issue being a "real hardware" issue rather than an sd2snes/FXPAK issue, with the in-game hook being able to mask it somehow (it has an impact on NMI execution timing). Why it works via USB remains a mystery.
Do you have a chance to test it on a SuperFX donor cart with EEPROM/Flash attached?

@Sunlitspace542
Copy link
Author

Sunlitspace542 commented Sep 13, 2024

Do you have a chance to test it on a SuperFX donor cart with EEPROM/Flash attached?

I don't, but I know someone who can.

@Ramsis-SNES
Copy link

Just for the record, I tried StarFox EX v1.04.3 (both the normal and the FastROM patch) with my sd2snes Mk. II rev. H, firmware v1.11.0/issue186 on an Analogue Super Nt, and there are no glitches/flickering on either the intro sequence or the title screen whatsoever.

Also, I do own a homebrew GSU-2 flash cartridge, but programming the thing is rather tedious, so ... yeah.

multi-fx-06

multi-fx-07

multi-fx-08

multi-fx-09

@Sunlitspace542
Copy link
Author

I tried SFEX 1.10.04 (current public release) and it flickers on the title screen. it's not very frequent though, so it can be easily missed.

@Sunlitspace542
Copy link
Author

Right now I am leaning towards the issue being a "real hardware" issue rather than an sd2snes/FXPAK issue, with the in-game hook being able to mask it somehow (it has an impact on NMI execution timing). Why it works via USB remains a mystery. Do you have a chance to test it on a SuperFX donor cart with EEPROM/Flash attached?

I just got the video back for the hardware test, no flickering at all.

SFNG.mp4

@Ramsis-SNES
Copy link

Ramsis-SNES commented Sep 17, 2024

I was able to reproduce the flickering on the title screen of SFEX 1.10.04 tonight. The only thing I changed from the setup mentioned in my previous post was to use a real (2-PPU) PAL SNES (SuperCIC-modded, 60 Hz) hooked up to my Sony PVM-14M2E.

The flickering only appeared after power-cycling and reloading the ROM twice, though. Also, it was extremely sporadic. From the looks of it, it could very well be an issue of the hack itself. (It shows garbled graphics for a split second right at the start, even before the kandowontu message, so it doesn't seem to be too polished as of yet. EDIT: The garbled graphics also happens with vanilla Starfox v1.2 as well as the Competition ROM, but not with most other SuperFX games. Also, it only ever happens right after loading the game from the menu, but not e.g. after pressing the Reset button when the game was already running. So this observation actually does not prove my point regarding the origin of the flickering. Instead, it might actually be an sd2snes/FXPAK issue of its own ... who knows?)

I might consider writing the ROM to my GSU-2 flash cart (sigh) to really get to the bottom of this ...

@Sunlitspace542
Copy link
Author

Sunlitspace542 commented Sep 21, 2024

The garbled graphics also happens with vanilla Starfox v1.2 as well as the Competition ROM, but not with most other SuperFX games. Also, it only ever happens right after loading the game from the menu, but not e.g. after pressing the Reset button when the game was already running.

I believe that just has to do with how Star Fox clears VRAM on first startup. Star Fox 2 runs on the same engine and it doesn't do it, presumably because either VRAM gets cleared properly on boot in that game, or it just waits longer to turn the screen back on to hide it.
Every emulator I've ever used to play Star Fox 1 also does the same quick flash of garbage on screen on boot, IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants