Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Can you integrate advanced inpaint mask generation ? #25

Open
1 task done
dendenmushy opened this issue Jul 19, 2024 · 2 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@dendenmushy
Copy link

dendenmushy commented Jul 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do?

Hey thanks mrhan1993 for your rework, is it possible to you to add this features on the image-generation ?
image

Be able to choose the model, reverse the mask generation, and generate the mask beforehand.

Proposed workflow

Maybe even create a new route for this use case due to generation step

Additional information

Fooocus original source code:
https://github.com/lllyasviel/Fooocus/blob/f597bf1ab653bd4bea8cb1e5cc7996348fbe8879/webui.py#L253

**inpaint_mask_image** = grh.Image(label='Mask Upload', source='upload', type='numpy', tool='sketch', height=500, brush_color="#FFFFFF", mask_opacity=1, elem_id='inpaint_mask_canvas')
                                **invert_mask_checkbox** = gr.Checkbox(label='Invert Mask When Generating', value=False)
                                **inpaint_mask_model** = gr.Dropdown(label='Mask generation model',

Mask generation function:
https://github.com/lllyasviel/Fooocus/blob/f597bf1ab653bd4bea8cb1e5cc7996348fbe8879/webui.py#L280

@dendenmushy dendenmushy added the enhancement New feature or request label Jul 19, 2024
@mrhan1993
Copy link
Owner

mrhan1993 commented Jul 19, 2024

support for v2.5.0 is ongoing, you can see progress in the v2.5.0 branch, maybe you can help test it and provide recommendations

@dendenmushy
Copy link
Author

dendenmushy commented Jul 19, 2024

Yes with pleasure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants